Port to protocol v3 #123
Merged
Port to protocol v3 #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
===========================================
- Coverage 84.93% 70.80% -14.14%
===========================================
Files 8 10 +2
Lines 717 942 +225
===========================================
+ Hits 609 667 +58
- Misses 108 275 +167
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sindrehan
force-pushed
the
port-to-new-protocol
branch
4 times, most recently
from
6641aa3 to
989f01f
Compare
sindrehan
force-pushed
the
port-to-new-protocol
branch
from
989f01f to
e2fc581
Compare
sindrehan
force-pushed
the
port-to-new-protocol
branch
from
f3226c4 to
991f7f1
Compare
Needed to be able to use the |-operator for python < 3.10
Provides some measure of type safety, and a bonus allows the editor to auto-complete the get function
We use snake case everywhere else in the SDK, so having this be CamelCase makes no sense.
Will make it easier to expose more of the battery properties in the future
Need to import annotations to support the |-operator in python <3.10
Having this class be the default for the client attributes (telemetry_watcher, ctrl_client, etc) automatically makes the error messages much better.
Generated with `protoc-gen-doc.sh` in `ProtocolDefinitions` checked out at the same commit as the submodule in v2.2.0 of `blueye.protocol`. Manually removed the Table of content from the markdown file (since MkDocs generates a ToC as well)
sindrehan
force-pushed
the
port-to-new-protocol
branch
from
11f3f98 to
4aeea7e
Compare
Neater to encapsulate the catching of the KeyError exception and also nice to get the automatic deserialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
Figure out a good interface for dealing with guest port peripheralsAdd gripper interface #129, Add laser interface #130, Add servo interface #131, Add interface for controlling DVL #132, Add interface for positioning systems #133Add new overlay parameters (thickness gauge, etc)Add support for missing overlay parameters #127Update documentation for new log file formatUpdate logs documentation #128KeyError)Breaking changes:
Noneif no telemetry message has been received yet from the drone.