nits from cargo test and cargo clippy on latest nightly
#65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
force-pushed
the
2023-05--fix-clippy
branch
from
5ad6102 to
78ffb56
Compare
|
cc @sanket1729 could you take a look at this? |
|
LGTM, will ACK after #54 is in. |
The newest nightly has a new "unused mut" warning which is causing CI to fail. Fix that, and while we're at it, run clippy. And while we're at that, remove some `#[deny]` conditions from the crate root since these properly belong in CI (via -D warnings) rather than in the source.
apoelstra
force-pushed
the
2023-05--fix-clippy
branch
from
78ffb56 to
e016ba9
Compare
|
Ok, rebased and should be good to go. This redoes a bit of the "add doccomments to re-exports" word but I think it does a better job, so I kept the new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newest nightly has a new "unused mut" warning which is causing CI to fail. Fix that, and while we're at it, run clippy. And while we're at that, remove some
#[deny]conditions from the crate root since these properly belong in CI (via -D warnings) rather than in the source.