nits from cargo test and cargo clippy on latest nightly

The newest nightly has a new "unused mut" warning which is causing CI to
fail. Fix that, and while we're at it, run clippy. And while we're at
that, remove some `#[deny]` conditions from the crate root since these
properly belong in CI (via -D warnings) rather than in the source.

Author: apoelstra

secp256k1-zkp-sys/src/zkp.rs

@@ -426,6 +426,12 @@ impl PartialEq for SurjectionProof {
 
 impl Eq for SurjectionProof {}
 
+impl Default for SurjectionProof {
+    fn default() -> Self {
+        SurjectionProof::new()
+    }
+}
+
 impl hash::Hash for SurjectionProof {
     fn hash<H: hash::Hasher>(&self, state: &mut H) {
         self.n_inputs.hash(state);
@@ -527,7 +533,7 @@ impl Default for PedersenCommitment {
 #[cfg(not(fuzzing))]
 impl PartialEq for PedersenCommitment {
     fn eq(&self, other: &Self) -> bool {
-        &self.0[..] == &other.0[..]
+        self.0[..] == other.0[..]
     }
 }
 
@@ -594,6 +600,12 @@ pub struct EcdsaAdaptorSignature([u8; ECDSA_ADAPTOR_SIGNATURE_LENGTH]);
 impl_array_newtype!(EcdsaAdaptorSignature, u8, ECDSA_ADAPTOR_SIGNATURE_LENGTH);
 impl_raw_debug!(EcdsaAdaptorSignature);
 
+impl Default for EcdsaAdaptorSignature {
+    fn default() -> EcdsaAdaptorSignature {
+        EcdsaAdaptorSignature::new()
+    }
+}
+
 impl EcdsaAdaptorSignature {
     /// Create a new (zeroed) ecdsa adaptor signature usable for the FFI interface
     pub fn new() -> Self {
@@ -617,7 +629,7 @@ impl EcdsaAdaptorSignature {
 #[cfg(not(fuzzing))]
 impl PartialEq for EcdsaAdaptorSignature {
     fn eq(&self, other: &Self) -> bool {
-        &self.0[..] == &other.0[..]
+        self.0[..] == other.0[..]
     }
 }
 

src/lib.rs

@@ -29,16 +29,14 @@
 //!
 
 // Coding conventions
-#![deny(non_upper_case_globals)]
-#![deny(non_camel_case_types)]
-#![deny(non_snake_case)]
-#![deny(unused_mut)]
 #![warn(missing_docs)]
 #![cfg_attr(all(not(test), not(feature = "std")), no_std)]
 #![cfg_attr(all(test, feature = "unstable"), feature(test))]
 
 #[macro_use]
+/// Re-export of the internal FFI bindings crate
 pub extern crate secp256k1_zkp_sys;
+/// Re-export of the internal FFI bindings crate under the alternate name `ffi`
 pub use secp256k1_zkp_sys as ffi;
 
 extern crate secp256k1;
@@ -47,10 +45,12 @@ extern crate secp256k1;
 pub use secp256k1::hashes;
 #[cfg(any(test, feature = "std"))]
 extern crate core;
+/// Re-export of the `rand` crate
 #[cfg(any(test, feature = "rand"))]
 pub extern crate rand;
-#[cfg(any(test))]
+#[cfg(test)]
 extern crate rand_core;
+/// Re-export of the `serde` crate
 #[cfg(feature = "serde")]
 pub extern crate serde;
 #[cfg(all(test, feature = "serde"))]

src/zkp/generator.rs

@@ -21,7 +21,7 @@ pub const ZERO_TWEAK: Tweak = Tweak([
 impl fmt::Debug for Tweak {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
         write!(f, "Tweak(")?;
-        for i in self[..].iter().cloned() {
+        for i in self[..].iter() {
             write!(f, "{:02x}", i)?;
         }
         write!(f, ")")

src/zkp/rangeproof.rs

@@ -65,6 +65,7 @@ impl RangeProof {
     }
 
     /// Prove that `commitment` hides a value within a range, with the lower bound set to `min_value`.
+    #[allow(clippy::too_many_arguments)]
     pub fn new<C: Signing>(
         secp: &Secp256k1<C>,
         min_value: u64,

src/zkp/surjection_proof.rs

@@ -152,6 +152,14 @@ impl SurjectionProof {
         }
     }
 
+    /// Whether the proof has zero length
+    ///
+    /// Always returns `false` since a surjection proof must contain at least
+    /// one 32-byte hash.
+    pub fn is_empty(&self) -> bool {
+        false
+    }
+
     /// Verify a surjection proof.
     #[must_use]
     pub fn verify<C: Verification>(

src/zkp/whitelist.rs

@@ -18,7 +18,7 @@ pub struct WhitelistSignature(ffi::WhitelistSignature);
 impl WhitelistSignature {
     /// Number of keys in the whitelist.
     pub fn n_keys(&self) -> usize {
-        self.0.n_keys as usize
+        self.0.n_keys
     }
 
     /// Serialize to bytes.
@@ -339,7 +339,7 @@ mod tests {
             // wrong n_keys
             let sig = unsafe {
                 let sig = correct_signature.clone();
-                let mut ptr = sig.as_c_ptr() as *mut ffi::WhitelistSignature;
+                let ptr = sig.as_c_ptr() as *mut ffi::WhitelistSignature;
                 (*ptr).n_keys -= 1;
                 sig
             };