Backport rust-secp 284 and 422 #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In line with the `Tests` job and for the fact that this job does stuff with the nightly toolchain other than bench. Re-name nightly CI job from `bench_nightly`to `Nightly`. Backport of a8a679ed7dbfa4871270de779aee78b3cdaeebd6: rust-bitcoin/rust-secp256k1#284 (2/9)
We use a matrix with a single element, this is unnecessary. Backport of 96685c571da4f3c64d178e0f0d3a02ce99de9136: rust-bitcoin/rust-secp256k1#284 (3/9)
The address sanitizer job is silently failing at the moment because we do not install clang. Install clang so the address sanitizer job can run. Do not fix the silent failure, that will be done later on. Backport of f7bc7d3728326e6de0d2462dfba9705b93a1f55e: rust-bitcoin/rust-secp256k1#284 (4/9)
We have a separate CI job for things that require a nightly toolchain. Building the docs requires a nightly toolchain (because of `--cfg docsrc` flag). It makes more sense to run the docs build in the `Nightly` job instead of hidden in the `Tests` job. Do the docs build in the `Nightly` job instead of in the `Tests` job. Backport of 946ac3b51ebb8191b051c8d80bd27bee1656993e: rust-bitcoin/rust-secp256k1#284 (5/9)
WASM is supported by Rust 1.30. We can therefore run the WASM tests on any all the toolchains except MSRV (1.29.0). This has benefit of catching nightly/beta issues before they get to stable. Done as a separate CI job since it is conceptually different to the `Tests` job. Run WASM for nightly, beta, and stable toolchains. Backport of 58db1b67536794b24cdc0bf8149460509a247b31: rust-bitcoin/rust-secp256k1#284 (6/9)
As per UNIX convention a Bash script should exit with status code 0 if it completes successfully. Backport of 7bec31c3a6eb43068f0b28db5f351b079751b2e2: rust-bitcoin/rust-secp256k1#284 (7/9)
For the test that uses `clang-9` do the sanity call using `clang-9` instead of `clang`. For the test that uses `clang` add a sanity call to `clang --version`. Backport of 97dc0ea9acdc308cc2cadc11e4787d07ec9b2c79: rust-bitcoin/rust-secp256k1#284 (9/9)
This was added in e0a4d2c (no associated PR) (Dec 2020).
apoelstra
force-pushed
the
2022-07--wasm-fix
branch
from
73e15bd to
5844f8a
Compare
|
cc @sanket1729 let's get this in |
sanket1729
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
ACK b0a1a69. Ignore the comment about clang-9, looks like it is not need for this secp-zkp CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47
(Actually I believe 47 is already fixed, but this re-enables the test in CI so we can be sure.)
Easiest way to review this is probably to add rust-secp as a remote and then use
range-diffto see how my versions of the commits change from those in the PR. I have provided commit IDs in my commit messages.