Skip to content

Add Simplicity LSP #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Add Simplicity LSP #158

wants to merge 0 commits into from

Conversation

@KyrylR
Copy link
Contributor

@KyrylR KyrylR commented Oct 31, 2025

No description provided.

@KyrylR KyrylR requested a review from imaginator as a code owner October 31, 2025 11:32
@KyrylR KyrylR marked this pull request as draft October 31, 2025 11:32
@KyrylR
Copy link
Contributor Author

KyrylR commented Oct 31, 2025

Blocked by the outdated SimplicityHL version

cc @imaginator

@apoelstra
Copy link
Contributor

apoelstra commented Nov 3, 2025

Blocked by the outdated SimplicityHL version

Do you mean the outdated rust-simplicity version?

@KyrylR
Copy link
Contributor Author

KyrylR commented Nov 3, 2025

This one: https://crates.io/crates/simplicityhl

@apoelstra
Copy link
Contributor

apoelstra commented Nov 3, 2025

I don't understand. Why would the LSP care about what's on crates.io?

This is the SimplicityHL repo. By definition it's the most up-to-date version of SimplicityHL.

@KyrylR
Copy link
Contributor Author

KyrylR commented Nov 3, 2025 •
edited
Loading

The main reasoning behind this is having the Simplicity LSP on crates.io

If it is there, instead of having three commands (git clone, cd, cargo install), you will have only one install command (better dev experience)

Simplicity LSP cannot be published to crates.io with a dependency that looks like this:

simplicityhl = { git = "https://github.com/BlockstreamResearch/SimplicityHL.git", rev = "e68e1c6" }

It must have a version tag

@apoelstra
Copy link
Contributor

apoelstra commented Nov 3, 2025

Ah, I understand, it's a draft until we can get it into a publishable state.

@apoelstra apoelstra mentioned this pull request Nov 4, 2025
Merged
apoelstra added a commit that referenced this pull request Nov 7, 2025
@apoelstra
Merge #160: update rust-simplicity to 0.6 and release SimplicityHL 0.3
5c250a4 
f76810c bump version to 0.3.0 (Andrew Poelstra)
f7c24df update rust-simplictiy to 0.6 (Andrew Poelstra)
2f41378 stick invariant <'brand> tag onto Scope and CoreExt (Andrew Poelstra)

Pull request description:

  Should unblock #158 and also let us update the webide.


ACKs for top commit:
  delta1:
    ACK f76810c 


Tree-SHA512: 03ac177a925e91007ae9e72d1bd0c6af3d0ce2b8fe2dd8b2fbfcd8efdfa78578670df7c3943b21d25d51b34f21f901feab35dfa6ffbeee4c9ac3529e94c3016c
@apoelstra
Copy link
Contributor

apoelstra commented Nov 11, 2025

Should this be undrafted? Also, can you please remove the merge commits from the PR?

@KyrylR KyrylR force-pushed the feature/lsp branch 2 times, most recently from a8ade8c to 7572cf2 Compare November 12, 2025 10:18
@KyrylR KyrylR closed this Nov 12, 2025
@KyrylR KyrylR mentioned this pull request Nov 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imaginator imaginator Awaiting requested review from imaginator

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KyrylR @apoelstra