Updated READMEs and deps. Implemented Go to References.

Author: KyrylR

.github/workflows/lsp-ci.yml

@@ -0,0 +1,62 @@
+name: LSP CI
+
+on:
+  pull_request:
+    paths:
+      - 'lsp/**'
+      - '.github/workflows/lsp-ci.yml'
+  push:
+    branches:
+      - master
+    paths:
+      - 'lsp/**'
+      - '.github/workflows/lsp-ci.yml'
+
+jobs:
+  fmt:
+    name: Rustfmt (lsp)
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Rust (stable)
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          components: rustfmt
+
+      - name: Check formatting
+        working-directory: lsp
+        run: cargo fmt --all -- --check
+
+  clippy:
+    name: Clippy (lsp)
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Rust (stable)
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          components: clippy
+
+      - name: Run clippy
+        working-directory: lsp
+        run: cargo clippy --all-targets --all-features
+
+  tests:
+    name: Tests (lsp)
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Rust (stable)
+        uses: dtolnay/rust-toolchain@stable
+
+      - name: Run tests
+        working-directory: lsp
+        run: cargo test --all-features -- --nocapture
+
+

.github/workflows/publish-lsp.yml

@@ -0,0 +1,95 @@
+name: Publish simplicityhl-lsp
+
+on:
+  push:
+    tags:
+      - 'simplicityhl-lsp-v*'
+  workflow_dispatch: {}
+  release:
+    types: [published]
+
+jobs:
+  lint:
+    name: Lint (lsp)
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Rust (stable)
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          components: clippy, rustfmt
+
+      - name: Rustfmt check
+        working-directory: lsp
+        run: cargo fmt --all -- --check
+
+      - name: Clippy
+        working-directory: lsp
+        run: cargo clippy --all-targets --all-features -D warnings
+
+  tests:
+    name: Tests (lsp)
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Rust (stable)
+        uses: dtolnay/rust-toolchain@stable
+
+      - name: Run tests
+        working-directory: lsp
+        run: cargo test --all-features -- --nocapture
+
+  publish:
+    name: Publish simplicityhl-lsp to crates.io
+    needs: [lint, tests]
+    runs-on: ubuntu-latest
+    environment: release
+    concurrency:
+      group: publish-lsp-${{ github.ref }}
+      cancel-in-progress: false
+    permissions:
+      id-token: write
+      contents: read
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Rust (stable)
+        uses: actions-rust-lang/setup-rust-toolchain@v1
+        with:
+          toolchain: stable
+
+      - name: Verify tag matches crate version
+        shell: bash
+        run: |
+          set -euo pipefail
+          TAG="${GITHUB_REF##*/}"
+          VERSION_TAG="${TAG#simplicityhl-lsp-v}"
+          CRATE_VERSION=$(cargo metadata --manifest-path lsp/Cargo.toml --no-deps --format-version=1 | jq -r '.packages[] | select(.name=="simplicityhl-lsp").version')
+          echo "Tag version: $VERSION_TAG"
+          echo "Crate version: $CRATE_VERSION"
+          if [ "$VERSION_TAG" != "$CRATE_VERSION" ]; then
+            echo "Tag version ($VERSION_TAG) does not match crate version ($CRATE_VERSION)"
+            exit 1
+          fi
+
+      - name: Check package
+        working-directory: lsp
+        run: cargo package
+
+      - name: Authenticate with crates.io
+        id: auth
+        uses: rust-lang/crates-io-auth-action@v1
+
+      - name: Publish
+        env:
+          CARGO_REGISTRY_TOKEN: ${{ steps.auth.outputs.token }}
+        working-directory: lsp
+        run: cargo publish
+
+

.github/workflows/rust.yml

@@ -169,3 +169,23 @@ jobs:
         uses: dtolnay/rust-toolchain@stable
       - run: rustup target add wasm32-unknown-unknown
       - run: cargo check --target wasm32-unknown-unknown
+
+  Fuzz:
+    name: Check Fuzz
+    needs: Prepare
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+    steps:
+      - name: "Checkout repo"
+        uses: actions/checkout@v4
+
+      - name: "Select nightly toolchain"
+        uses: dtolnay/rust-toolchain@v1
+        with:
+          toolchain: ${{ needs.Prepare.outputs.nightly_version }}
+
+      - name: "Check fuzz crate"
+        run: |
+          cargo check --manifest-path=fuzz/Cargo.toml
+

Cargo.lock

@@ -38,8 +38,8 @@ clap = "4.5.37"
 getrandom = { version = "0.2", features = ["js"] }
 
 [workspace]
-members = ["codegen"]
-exclude = ["fuzz", "bitcoind-tests"]
+members = ["codegen", "fuzz"]
+exclude = ["bitcoind-tests", "lsp"]
 
 [lints.clippy]
 # Exclude lints we don't think are valuable.

Cargo.toml

@@ -20,7 +20,7 @@ Take a look at the [example programs](https://github.com/BlockstreamResearch/Sim
 
 ## MSRV
 
-This crate should compile with any feature combination on **Rust 1.78.0** or higher.
+This crate should compile with any feature combination on **Rust 1.79.0** or higher.
 
 ## Simplicity's need for a high-level language
 

README.md

@@ -1,4 +1,4 @@
-msrv = "1.78.0"
+msrv = "1.79.0"
 # We have an error type, `RichError`, of size 144. This is pushing it but probably fine.
 large-error-threshold = 145
 

clippy.toml

@@ -14,6 +14,12 @@ simplicityhl = { path = "..", features = ["arbitrary", "serde"] }
 itertools = "0.13.0"
 serde_json = "1.0.105"
 
+[dev-dependencies]
+base64 = "0.22.1"
+
+[lints.rust]
+unexpected_cfgs = { level = "deny", check-cfg = ['cfg(fuzzing)'] }
+
 [[bin]]
 name = "compile_text"
 path = "fuzz_targets/compile_text.rs"

fuzz/Cargo.toml

@@ -1,12 +1,12 @@
-#![no_main]
+#![cfg_attr(fuzzing, no_main)]
 
-use arbitrary::Arbitrary;
-use libfuzzer_sys::fuzz_target;
+#[cfg(any(fuzzing, test))]
+fn do_test(data: &[u8]) {
+    use arbitrary::Arbitrary;
 
-use simplicityhl::error::WithFile;
-use simplicityhl::{ast, named, parse, ArbitraryOfType, Arguments};
+    use simplicityhl::error::WithFile;
+    use simplicityhl::{ast, named, parse, ArbitraryOfType, Arguments};
 
-fuzz_target!(|data: &[u8]| {
     let mut u = arbitrary::Unstructured::new(data);
     let parse_program = match parse::Program::arbitrary(&mut u) {
         Ok(x) => x,
@@ -24,6 +24,24 @@ fuzz_target!(|data: &[u8]| {
         .compile(arguments, false)
         .with_file("")
         .expect("AST should compile with given arguments");
-    let _simplicity_commit = named::to_commit_node(&simplicity_named_construct)
-        .expect("Conversion to commit node should never fail");
-});
+    let _simplicity_commit = named::forget_names(&simplicity_named_construct);
+}
+
+#[cfg(fuzzing)]
+libfuzzer_sys::fuzz_target!(|data| do_test(data));
+
+#[cfg(not(fuzzing))]
+fn main() {}
+
+#[cfg(test)]
+mod tests {
+    use base64::Engine;
+
+    #[test]
+    fn duplicate_crash() {
+        let data = base64::prelude::BASE64_STANDARD
+            .decode("Cg==")
+            .expect("base64 should be valid");
+        super::do_test(&data);
+    }
+}