Skip to content

ci: run unit tests on macos #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
+76 −51
Draft

ci: run unit tests on macos #1668

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5aa113c
ci: run unit tests on macos
NickeZ Nov 3, 2025
1e32a71
fixup! ci: run unit tests on macos
NickeZ Nov 3, 2025
496a2c8
fixup! ci: run unit tests on macos
NickeZ Nov 3, 2025
28b1322
fixup! ci: run unit tests on macos
NickeZ Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/workflows/ci-common.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,33 @@ jobs:
- name: run ATECC608 unit tests
run: (cd tools/atecc608; go test ./...)

unit-tests-macos:
Copy link
Collaborator

@benma benma Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call it rust-unit-tests-macos?

runs-on: macos-14
steps:
- name: Clone the repo
uses: actions/checkout@v4
with:
fetch-depth: 0
fetch-tags: true
submodules: recursive

- name: Install system dependencies
run: brew install cbindgen bindgen cmocka hidapi
Copy link
Collaborator

@benma benma Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hidapi should not be needed?

cmocka also not for Ruts unit tests?

Copy link
Collaborator Author

@NickeZ NickeZ Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, cmocka shouldn't be a requirement. hidapi is needed to build the u2f unit tests. I suppose we could make hidapi an optional dependnecy, but then if hidapi is missing it will fail to build instead of fail to configure. Not sure if that is better...

Copy link
Collaborator Author

@NickeZ NickeZ Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed some commits to see if I can get rid of the cmocka dep at least.


- name: Install protoc
uses: arduino/setup-protoc@v3
with:
version: "21.x"
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Install rust
uses: actions-rust-lang/setup-rust-toolchain@v1
with:
rust-src-dir: src/rust

- name: Run rust unit-tests
run: make run-rust-unit-tests

leakcheck:
runs-on: ubuntu-22.04
container: ${{ inputs.container-repo }}:${{ inputs.container-version }}
Expand Down
Loading