ci: run unit tests on macos #1668
Draft
+76
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickeZ
force-pushed
the
maint/unit-test-in-macos
branch
5 times, most recently
from
19cbfe5 to
b69cdd3
Compare
NickeZ
force-pushed
the
maint/unit-test-in-macos
branch
from
b69cdd3 to
5aa113c
Compare
benma
reviewed
Nov 3, 2025
.github/workflows/ci-common.yml
Outdated
| - name: run ATECC608 unit tests | ||
| run: (cd tools/atecc608; go test ./...) | ||
|
|
||
| unit-tests-macos: |
There was a problem hiding this comment.
call it rust-unit-tests-macos?
.github/workflows/ci-common.yml
Outdated
| submodules: recursive | ||
|
|
||
| - name: Install system dependencies | ||
| run: brew install cbindgen bindgen cmocka hidapi |
There was a problem hiding this comment.
hidapi should not be needed?
cmocka also not for Ruts unit tests?
There was a problem hiding this comment.
yeah, cmocka shouldn't be a requirement. hidapi is needed to build the u2f unit tests. I suppose we could make hidapi an optional dependnecy, but then if hidapi is missing it will fail to build instead of fail to configure. Not sure if that is better...
There was a problem hiding this comment.
pushed some commits to see if I can get rid of the cmocka dep at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.