Repository navigation
Validate model names in explicit XML node syntax - #1231
Merged
facontidavide merged 1 commit intoOct 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicit node syntax currently bypasses model-name validation: a registered ID such as
<Action ID="Node.With.Dot"/>is accepted even though compact syntax rejects the same model name. Validate the resolved lookup name for both forms, including Action, Condition, Decorator and Control wrappers.Fixes #1220.
This changes XML parsing behavior for explicit IDs that violate the documented model-name rules. Valid ASCII/Unicode IDs and relaxed instance names remain supported; programmatic registration and the public API/ABI are unchanged.
Validation: