-
Notifications
You must be signed in to change notification settings - Fork 152
Add NativeEncoding plugin #1555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexchuber
wants to merge
20
commits into
BabylonJS:master
Choose a base branch
from
alexchuber:add-native-encoding
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+214
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexchuber
commented
Oct 15, 2025
bghgary
approved these changes
Oct 15, 2025
) that should be replaced by this PR change. It's being used by https://github.com/BabylonJS/BabylonNative/blob/master/Apps/Playground/Scripts/validation_native.js |
ryantrem
approved these changes
Oct 16, 2025
Totally. Will do this in a follow-up PR. |
alexchuber
commented
Oct 22, 2025
}) | ||
.then(*runtimeScheduler, arcana::cancellation_source::none(), | ||
[runtimeScheduler, deferred, env](const arcana::expected<std::vector<uint8_t>, std::exception_ptr>& result) { | ||
// TODO: Crash risk on JS teardown - this async work isn't tied to any JS object lifetime, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See issue #1558
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
NativeEncoding
plugin, which provides native image encoding capabilities to JavaScript. Raw pixel data can be encoded into standard image formats (PNG, JPEG, WebP, etc.), serving Babylon.js's needs for texture export.See the README for more info.
As this PR is focused on the plugin (and some smoke tests for it), the following will be delegated to future PRs: