Skip to content

Conversation

@qianglbl
Copy link
Member

fixed Gauss3dPush and added 2.5D SC with transverse Gaussian distribution.

@qianglbl qianglbl requested review from ax3l and cemitch99 September 30, 2025 16:00


int tp5d_bins = 129;
// pp_algo.queryAddWithParser("tp5d_bins", tp5d_bins);

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
// pp_algo.queryAddWithParser("tp5d_bins", tp5d_bins);

// Measure beam size, extract the min, max of particle positions
[[maybe_unused]] auto const [x_min, y_min, t_min, x_max, y_max, t_max] =

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable x_min is not used.
// pp_algo.queryAddWithParser("tp5d_bins", tp5d_bins);

// Measure beam size, extract the min, max of particle positions
[[maybe_unused]] auto const [x_min, y_min, t_min, x_max, y_max, t_max] =

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable y_min is not used.
// pp_algo.queryAddWithParser("tp5d_bins", tp5d_bins);

// Measure beam size, extract the min, max of particle positions
[[maybe_unused]] auto const [x_min, y_min, t_min, x_max, y_max, t_max] =

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable x_max is not used.
// pp_algo.queryAddWithParser("tp5d_bins", tp5d_bins);

// Measure beam size, extract the min, max of particle positions
[[maybe_unused]] auto const [x_min, y_min, t_min, x_max, y_max, t_max] =

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable y_max is not used.
*
* This calculates the space charge fields from a 3D Gaussian distribution
* with respect to particle position from the following paper.
* "Two-and-a-half dimensional symplectic space-charge slover"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This citation looks incomplete.

Copy link
Member

@cemitch99 cemitch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! The only failing tests occur on GPU, due to a host-device error that we can fix. Do you have a test in mind for the Gauss2p5d case? We can exchange some ideas this afternoon.

@ax3l
Copy link
Member

ax3l commented Oct 7, 2025

Continued in #1166

@ax3l ax3l closed this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants