Gauss 3D: Fix Push Constants #1168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the push constants for non-equal x,y,z and adds an end-point correction for the integration. It also changes the number of integration points by default to 101 instead of 401.
ax3l
added
bug
qianglbl
approved these changes
Oct 7, 2025
ax3l
added a commit
to ax3l/impactx
that referenced
this pull request
Oct 17, 2025
* [pre-commit.ci] pre-commit autoupdate (BLAST-ImpactX#1161) updates: - [github.com/astral-sh/ruff-pre-commit: v0.13.1 → v0.13.2](astral-sh/ruff-pre-commit@v0.13.1...v0.13.2) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [pre-commit.ci] pre-commit autoupdate (BLAST-ImpactX#1165) updates: - [github.com/astral-sh/ruff-pre-commit: v0.13.2 → v0.13.3](astral-sh/ruff-pre-commit@v0.13.2...v0.13.3) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Gauss 3D: Fix Push Constants (BLAST-ImpactX#1168) This fixes the push constants for non-equal x,y,z and adds an end-point correction for the integration. It also changes the number of integration points by default to 101 instead of 401. Co-authored-by: Ji Qiang <[email protected]> * [pre-commit.ci] pre-commit autoupdate (BLAST-ImpactX#1174) updates: - [github.com/astral-sh/ruff-pre-commit: v0.13.3 → v0.14.0](astral-sh/ruff-pre-commit@v0.13.3...v0.14.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Bump stefanzweifel/git-auto-commit-action from 6 to 7 (BLAST-ImpactX#1175) Bumps [stefanzweifel/git-auto-commit-action](https://github.com/stefanzweifel/git-auto-commit-action) from 6 to 7. - [Release notes](https://github.com/stefanzweifel/git-auto-commit-action/releases) - [Changelog](https://github.com/stefanzweifel/git-auto-commit-action/blob/master/CHANGELOG.md) - [Commits](stefanzweifel/git-auto-commit-action@v6...v7) --- updated-dependencies: - dependency-name: stefanzweifel/git-auto-commit-action dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github/codeql-action from 3 to 4 (BLAST-ImpactX#1176) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3 to 4. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v3...v4) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix `BeamMonitor`: Delay Open (BLAST-ImpactX#1178) `BeamMonitor` opens the openPMD series now on first output. This simplifies usage dramatically, now allowing to: * create the lattice (monitor elements) before the `sim` is even initialized * creating a monitor element and not using it in a lattice * CMake `pip_install`: Package Examples (BLAST-ImpactX#1179) Ensure the `examples/` directory is part of the `pip` wheels we build, e.g., on `cmake --build build -j 6 --target pip_install` * Envelope: Silence Warning w/o Space-Charge (BLAST-ImpactX#1173) Consistent with the other two tracking modes, we only print options upfront and do not warn every simulation step if space charge is not used. * Release 25.10 (BLAST-ImpactX#1180) * Update Stub Files * AMReX/ABLASTR/WarpX: development (BLAST-ImpactX#1177) * ABLASTR/WarpX: development Update the ABLASTR dependency to the latest development branch. * pyAMReX: `development` * Python: Improve `KnownElementsList` (BLAST-ImpactX#1181) Add per-element by-reference access for manipulation. * Update Stub Files * Element Selection Syntax (BLAST-ImpactX#1182) * Implementation 5hr vibe pair coded in Cursor. Maybe should have just done it xD * Doc * Fix Type Hints * `select`: Fix All-Selected Path Avoid implicit return of `None` * Cleanup * Update Stub Files * Fix Python import errors (BLAST-ImpactX#1186) * Update Stub Files * Fix RFCavity edge case (BLAST-ImpactX#1185) * Fix RFCavity edge case. * Remove extra semicolon. * Fix el typing (BLAST-ImpactX#1190) * Fix `KnownElementsList` Stubs Avoid importing `typing` for type hints, because pybind11-stubgen forgets the import when generating `pyi` files... * Update Stubs * Update PALS to 0.2.0 (BLAST-ImpactX#1184) * Update PALS version * Fix missing imports in KnownElementsList.pyi * Fix FODO example script * Revert changes to stub file * fix some math issues in examle documentation (BLAST-ImpactX#1191) * "Starting step" Print: Spaces (BLAST-ImpactX#1187) - newline before new step - no space before `++++ Starting step` * Element Names: All, `None` (BLAST-ImpactX#1189) It is easier for user-facing workflows if `.name` exists for all elements, even `Empty`. In Python, instead of throwing an exception we return the `None` value for elements without a user-provided name, which simplifies user-logic. In this case `.has_name` is `False`. * Update Stub Files --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Axel Huebl <[email protected]> Co-authored-by: Ji Qiang <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ax3l <[email protected]> Co-authored-by: Edoardo Zoni <[email protected]> Co-authored-by: Richard Pausch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the push constants in #1127 for non-equal sigma in x,y,z and adds an end-point correction for the integration. It also changes the number of integration points by default to 101 instead of 401.
Fix spotted and developed by @qianglbl.
Isolated from #1163 #1166 for clarity.