-
Couldn't load subscription status.
- Fork 2.7k
Update axios #8082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Update axios #8082
Changes from 5 commits
70efcca
f64a584
77e3fe1
68fd2d6
6aacba3
3a3363a
49341f2
6a56eca
0a07c4a
653da3d
3dc5350
8d0c30d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,29 @@ | ||
| { | ||
| "name": "electron-test-app", | ||
| "version": "1.0.0", | ||
| "description": "A sample Electron application that uses msal-node to acquire tokens", | ||
| "main": "App.ts", | ||
| "private": true, | ||
| "scripts": { | ||
| "build": "tsc", | ||
| "start": "npm run build && electron dist/app.js", | ||
| "build:package": "cd ../../../lib/msal-common && npm run build && cd ../msal-node && npm run build", | ||
| "start:build": "npm run build:package && npm start" | ||
| }, | ||
| "keywords": [ | ||
| "msal-node", | ||
| "electron", | ||
| "javascript" | ||
| ], | ||
| "author": "", | ||
| "license": "MIT", | ||
| "devDependencies": { | ||
| "babel": "^6.23.0", | ||
| "electron": "^22.3.25", | ||
| "typescript": "^4.1.2" | ||
| }, | ||
| "dependencies": { | ||
| "@azure/msal-node": "^3.0.0", | ||
| "axios": "^1.9.0" | ||
| } | ||
| "name": "electron-test-app", | ||
| "version": "1.0.0", | ||
| "description": "A sample Electron application that uses msal-node to acquire tokens", | ||
| "main": "App.ts", | ||
| "private": true, | ||
| "scripts": { | ||
| "build": "tsc", | ||
| "start": "npm run build && electron dist/app.js", | ||
| "build:package": "cd ../../../lib/msal-common && npm run build && cd ../msal-node && npm run build", | ||
| "start:build": "npm run build:package && npm start" | ||
| }, | ||
| "keywords": [ | ||
| "msal-node", | ||
| "electron", | ||
| "javascript" | ||
| ], | ||
| "author": "", | ||
| "license": "MIT", | ||
| "devDependencies": { | ||
| "babel": "^6.23.0", | ||
| "electron": "^22.3.25", | ||
| "typescript": "^4.1.2" | ||
| }, | ||
| "dependencies": { | ||
| "@azure/msal-node": "^3.0.0", | ||
| "axios": "^1.12.0" | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,34 @@ | ||
| { | ||
| "name": "msal-node-webapp", | ||
| "version": "1.0.0", | ||
| "description": "", | ||
| "main": "app.js", | ||
| "scripts": { | ||
| "clean": "rimraf ./build", | ||
| "build": "npm run clean && tsc", | ||
| "start": "node src/app.ts", | ||
| "dev": "ts-node src/app.ts", | ||
| "dev:watch": "nodemon src/app.ts -e ts,json --exec 'npm run dev'" | ||
| }, | ||
| "author": "", | ||
| "license": "ISC", | ||
| "devDependencies": { | ||
| "@types/express": "^4.17.17", | ||
| "@types/express-session": "^1.17.6", | ||
| "@types/node": "^18.14.1", | ||
| "nodemon": "^2.0.20", | ||
| "rimraf": "^4.1.2", | ||
| "ts-node": "^10.9.1", | ||
| "typescript": "^4.9.5" | ||
| }, | ||
| "dependencies": { | ||
| "@azure/msal-node": "^1.15.0", | ||
| "axios": "^1.9.0", | ||
| "connect-redis": "^7.0.0", | ||
| "dotenv": "^16.5.0", | ||
| "express": "^4.20.0", | ||
| "express-session": "^1.17.3", | ||
| "hbs": "^4.2.0", | ||
| "redis": "^4.6.5" | ||
| } | ||
| "name": "msal-node-webapp", | ||
| "version": "1.0.0", | ||
| "description": "", | ||
| "main": "app.js", | ||
| "scripts": { | ||
| "clean": "rimraf ./build", | ||
| "build": "npm run clean && tsc", | ||
| "start": "node src/app.ts", | ||
| "dev": "ts-node src/app.ts", | ||
| "dev:watch": "nodemon src/app.ts -e ts,json --exec 'npm run dev'" | ||
| }, | ||
| "author": "", | ||
| "license": "ISC", | ||
| "devDependencies": { | ||
| "@types/express": "^4.17.17", | ||
| "@types/express-session": "^1.17.6", | ||
| "@types/node": "^18.14.1", | ||
| "nodemon": "^2.0.20", | ||
| "rimraf": "^4.1.2", | ||
| "ts-node": "^10.9.1", | ||
| "typescript": "^4.9.5" | ||
| }, | ||
| "dependencies": { | ||
| "@azure/msal-node": "^1.15.0", | ||
| "axios": "^1.12.0", | ||
| "connect-redis": "^7.0.0", | ||
| "dotenv": "^16.5.0", | ||
| "express": "^4.20.0", | ||
| "express-session": "^1.17.3", | ||
| "hbs": "^4.2.0", | ||
| "redis": "^4.6.5" | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,30 @@ | ||
| { | ||
| "name": "msal-node-b2c-confidential", | ||
| "version": "1.0.0", | ||
| "description": "sample for msal-node confidential client application using using auth code flow to sign-in users on azure ad b2c", | ||
| "main": "index.js", | ||
| "private": true, | ||
| "scripts": { | ||
| "start": "node ./index.js", | ||
| "test:e2e": "jest", | ||
| "build:package": "cd ../../../lib/msal-common && npm run build && cd ../msal-node && npm run build", | ||
| "start:build": "npm run build:package && npm start" | ||
| }, | ||
| "author": "Microsoft", | ||
| "license": "MIT", | ||
| "dependencies": { | ||
| "@azure/msal-node": "^3.0.0", | ||
| "axios": "^1.9.0", | ||
| "dotenv": "^16.5.0", | ||
| "express": "^4.20.0", | ||
| "express-handlebars": "^5.3.5", | ||
| "express-session": "^1.17.2" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/jest": "^29.5.0", | ||
| "e2e-test-utils": "file:../../e2eTestUtils", | ||
| "jest": "^29.5.0", | ||
| "jest-junit": "^16.0.0", | ||
| "ts-jest": "^29.1.0" | ||
| } | ||
| "name": "msal-node-b2c-confidential", | ||
| "version": "1.0.0", | ||
| "description": "sample for msal-node confidential client application using using auth code flow to sign-in users on azure ad b2c", | ||
| "main": "index.js", | ||
| "private": true, | ||
| "scripts": { | ||
| "start": "node ./index.js", | ||
| "test:e2e": "jest", | ||
| "build:package": "cd ../../../lib/msal-common && npm run build && cd ../msal-node && npm run build", | ||
| "start:build": "npm run build:package && npm start" | ||
| }, | ||
| "author": "Microsoft", | ||
| "license": "MIT", | ||
| "dependencies": { | ||
| "@azure/msal-node": "^3.0.0", | ||
| "axios": "^1.12.0", | ||
| "dotenv": "^16.5.0", | ||
| "express": "^4.20.0", | ||
| "express-handlebars": "^5.3.5", | ||
| "express-session": "^1.17.2" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/jest": "^29.5.0", | ||
| "e2e-test-utils": "^0.0.1", | ||
| "jest": "^29.5.0", | ||
| "jest-junit": "^16.0.0", | ||
| "ts-jest": "^29.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,30 @@ | ||
| { | ||
| "name": "msal-node-daemon", | ||
| "version": "1.0.0", | ||
| "description": "", | ||
| "main": "index.js", | ||
| "scripts": { | ||
| "clean": "rimraf ./build", | ||
| "build": "npm run clean && tsc", | ||
| "start": "node src", | ||
| "dev": "ts-node src", | ||
| "dev:watch": "nodemon src -e ts, json --exec 'npm run dev'" | ||
| }, | ||
| "author": "", | ||
| "license": "ISC", | ||
| "devDependencies": { | ||
| "@types/node": "^18.14.1", | ||
| "nodemon": "^2.0.20", | ||
| "rimraf": "^4.1.2", | ||
| "ts-node": "^10.9.1", | ||
| "typescript": "^4.9.5" | ||
| }, | ||
| "dependencies": { | ||
| "@azure/msal-node": "^3.0.0", | ||
| "axios": "^1.9.0", | ||
| "dotenv": "^16.5.0", | ||
| "open": "^8.4.2", | ||
| "redis": "^4.6.5", | ||
| "yargs": "^17.7.1" | ||
| } | ||
| "name": "msal-node-daemon", | ||
| "version": "1.0.0", | ||
| "description": "", | ||
| "main": "index.js", | ||
| "scripts": { | ||
| "clean": "rimraf ./build", | ||
| "build": "npm run clean && tsc", | ||
| "start": "node src", | ||
| "dev": "ts-node src", | ||
| "dev:watch": "nodemon src -e ts, json --exec 'npm run dev'" | ||
| }, | ||
| "author": "", | ||
| "license": "ISC", | ||
| "devDependencies": { | ||
| "@types/node": "^18.14.1", | ||
| "nodemon": "^2.0.20", | ||
| "rimraf": "^4.1.2", | ||
| "ts-node": "^10.9.1", | ||
| "typescript": "^4.9.5" | ||
| }, | ||
| "dependencies": { | ||
| "@azure/msal-node": "^3.0.0", | ||
| "axios": "^1.12.0", | ||
| "dotenv": "^16.5.0", | ||
| "open": "^8.4.2", | ||
| "redis": "^4.6.5", | ||
| "yargs": "^17.7.1" | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,33 @@ | ||
| { | ||
| "name": "msal-node-webapi", | ||
| "version": "1.0.0", | ||
| "description": "", | ||
| "main": "app.js", | ||
| "scripts": { | ||
| "clean": "rimraf ./build", | ||
| "build": "npm run clean && tsc", | ||
| "start": "node src/app.ts", | ||
| "dev": "ts-node src/app.ts", | ||
| "dev:watch": "nodemon src/app.ts -e ts,json --exec 'npm run dev'" | ||
| }, | ||
| "author": "", | ||
| "license": "ISC", | ||
| "devDependencies": { | ||
| "@types/express": "^4.17.17", | ||
| "@types/jsonwebtoken": "^9.0.1", | ||
| "@types/node": "^18.14.1", | ||
| "nodemon": "^2.0.20", | ||
| "rimraf": "^4.1.2", | ||
| "ts-node": "^10.9.1", | ||
| "typescript": "^4.9.5" | ||
| }, | ||
| "dependencies": { | ||
| "@azure/msal-node": "^3.0.0", | ||
| "axios": "^1.9.0", | ||
| "dotenv": "^16.5.0", | ||
| "express": "^4.20.0", | ||
| "jsonwebtoken": "^9.0.0", | ||
| "jwks-rsa": "^3.0.1", | ||
| "redis": "^4.6.5" | ||
| } | ||
| "name": "msal-node-webapi", | ||
| "version": "1.0.0", | ||
| "description": "", | ||
| "main": "app.js", | ||
| "scripts": { | ||
| "clean": "rimraf ./build", | ||
| "build": "npm run clean && tsc", | ||
| "start": "node src/app.ts", | ||
| "dev": "ts-node src/app.ts", | ||
| "dev:watch": "nodemon src/app.ts -e ts,json --exec 'npm run dev'" | ||
| }, | ||
| "author": "", | ||
| "license": "ISC", | ||
| "devDependencies": { | ||
| "@types/express": "^4.17.17", | ||
| "@types/jsonwebtoken": "^9.0.1", | ||
| "@types/node": "^18.14.1", | ||
| "nodemon": "^2.0.20", | ||
| "rimraf": "^4.1.2", | ||
| "ts-node": "^10.9.1", | ||
| "typescript": "^4.9.5" | ||
| }, | ||
| "dependencies": { | ||
| "@azure/msal-node": "^3.0.0", | ||
| "axios": "^1.12.0", | ||
| "dotenv": "^16.5.0", | ||
| "express": "^4.20.0", | ||
| "jsonwebtoken": "^9.0.0", | ||
| "jwks-rsa": "^3.0.1", | ||
| "redis": "^4.6.5" | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,30 @@ | ||
| { | ||
| "name": "msal-node-silent-flow", | ||
| "version": "1.0.0", | ||
| "description": "sample app for msal-node", | ||
| "main": "index.js", | ||
| "private": true, | ||
| "scripts": { | ||
| "start": "node index.js", | ||
| "test:e2e": "jest", | ||
| "test:agc": "jest --testMatch [ '**/test/**/*agc*.spec.ts' ]", | ||
| "build:package": "cd ../../.. && npm run build:all --workspace=lib/msal-node" | ||
| }, | ||
| "author": "Microsoft", | ||
| "license": "MIT", | ||
| "dependencies": { | ||
| "@azure/msal-node": "^3.0.0", | ||
| "axios": "^1.9.0", | ||
| "dotenv": "^16.5.0", | ||
| "express": "^4.20.0", | ||
| "express-handlebars": "^5.3.5", | ||
| "express-promise-router": "^4.0.1" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/jest": "^29.5.0", | ||
| "e2e-test-utils": "file:../../e2eTestUtils", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A reference to the local package is intentional here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks. The change was not intentional, co-pilot suggestion I believe. Will revert this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a good catch, how do we prevent reverting this in the future? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. May be a lint rule? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add one? There's going to be a CVE asking folks to move to 4.25.1 when we moved the e2e tests and our lint rules to file references. We really shouldn't regress this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a devDependency on samples, we shouldn't be opening a CVE or pushing folks to upgrade for this. We should still avoid regressing this for our own sake though |
||
| "jest": "^29.5.0", | ||
| "jest-junit": "^16.0.0", | ||
| "ts-jest": "^29.1.0" | ||
| } | ||
| "name": "msal-node-silent-flow", | ||
| "version": "1.0.0", | ||
| "description": "sample app for msal-node", | ||
| "main": "index.js", | ||
| "private": true, | ||
| "scripts": { | ||
| "start": "node index.js", | ||
| "test:e2e": "jest", | ||
| "test:agc": "jest --testMatch [ '**/test/**/*agc*.spec.ts' ]", | ||
| "build:package": "cd ../../.. && npm run build:all --workspace=lib/msal-node" | ||
| }, | ||
| "author": "Microsoft", | ||
| "license": "MIT", | ||
| "dependencies": { | ||
| "@azure/msal-node": "^3.0.0", | ||
| "axios": "^1.12.0", | ||
| "dotenv": "^16.5.0", | ||
| "express": "^4.20.0", | ||
| "express-handlebars": "^5.3.5", | ||
| "express-promise-router": "^4.0.1" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/jest": "^29.5.0", | ||
| "e2e-test-utils": "^0.0.1", | ||
| "jest": "^29.5.0", | ||
| "jest-junit": "^16.0.0", | ||
| "ts-jest": "^29.1.0" | ||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.