Update axios #8082
Update axios #8082
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the axios dependency from version ^1.9.0 to ^1.12.0 across multiple MSAL.js sample applications and test utilities. This is a dependency version update that likely includes bug fixes, security patches, or new features from the axios library.
Key changes:
- Updated axios version constraint from ^1.9.0 to ^1.12.0 across all affected packages
- Changes are limited to sample applications and test utilities, not core library packages
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| samples/msal-node-samples/silent-flow/package.json | Updated axios dependency version |
| samples/msal-node-samples/on-behalf-of-distributed-cache/package.json | Updated axios dependency version |
| samples/msal-node-samples/client-credentials-distributed-cache/package.json | Updated axios dependency version |
| samples/msal-node-samples/b2c-user-flows/package.json | Updated axios dependency version |
| samples/msal-node-samples/auth-code-distributed-cache/package.json | Updated axios dependency version |
| samples/msal-node-samples/auth-code-cli-app/package.json | Updated axios dependency version |
| samples/msal-node-samples/ElectronTestApp/package.json | Updated axios dependency version |
| samples/msal-node-samples/ElectronSystemBrowserTestApp/package.json | Updated axios dependency version |
| samples/e2eTestUtils/package.json | Updated axios dependency version |
| }, | ||
| "devDependencies": { | ||
| "@types/jest": "^29.5.0", | ||
| "e2e-test-utils": "file:../../e2eTestUtils", |
There was a problem hiding this comment.
A reference to the local package is intentional here.
There was a problem hiding this comment.
Thanks. The change was not intentional, co-pilot suggestion I believe. Will revert this.
There was a problem hiding this comment.
This is a good catch, how do we prevent reverting this in the future?
There was a problem hiding this comment.
Can you add one? There's going to be a CVE asking folks to move to 4.25.1 when we moved the e2e tests and our lint rules to file references. We really shouldn't regress this.
There was a problem hiding this comment.
This is a devDependency on samples, we shouldn't be opening a CVE or pushing folks to upgrade for this. We should still avoid regressing this for our own sake though
sameerag
dismissed stale reviews from hectormmg and konstantin-msft
via
3dc5350
5 participants
Update axios version in samples