Allow targeting of a URL in proxy template#15500
Conversation
heaths
left a comment
There was a problem hiding this comment.
Not blocking despite my question because maybe it's fine. Just not expected since the diff was unexpected.
There was a problem hiding this comment.
Pull request overview
This PR updates the shared test-proxy pipeline templates so callers can override the proxy bind URL instead of always using the default localhost:5000 endpoint.
Changes:
- Adds a new
proxyUrlparameter to both common test-proxy templates. - Passes
proxyUrlthrough to the proxy startup command viastart ... -- --urls. - Switches the post-start
Admin/IsAliveprobe to use the configured URL.
Show a summary per file
| File | Description |
|---|---|
eng/common/testproxy/test-proxy-tool.yml |
Adds configurable proxy URL support to the standard test-proxy template for startup and health checks. |
eng/common/testproxy/test-proxy-standalone-tool.yml |
Mirrors the same configurable proxy URL behavior in the standalone test-proxy template. |
Copilot's findings
Comments suppressed due to low confidence (2)
eng/common/testproxy/test-proxy-tool.yml:110
--urlsaccepts ASP.NET-style bind strings such ashttp://localhost:9000;https://localhost:9001and wildcard hosts likehttp://0.0.0.0:0, but this readiness check treatsproxyUrlas a single client URL by appending/Admin/IsAlive. Those valid bind values produce an invalid or unroutable probe URI, so the template can fail even when the proxy starts successfully.
Write-Host "Invoke-WebRequest -Uri `"${{ parameters.proxyUrl }}/Admin/IsAlive`" | Out-Null"
Invoke-WebRequest -Uri "${{ parameters.proxyUrl }}/Admin/IsAlive" | Out-Null
eng/common/testproxy/test-proxy-standalone-tool.yml:98
--urlsaccepts ASP.NET-style bind strings such ashttp://localhost:9000;https://localhost:9001and wildcard hosts likehttp://0.0.0.0:0, but this readiness check treatsproxyUrlas a single client URL by appending/Admin/IsAlive. Those valid bind values produce an invalid or unroutable probe URI, so the template can fail even when the proxy starts successfully.
Write-Host "Invoke-WebRequest -Uri `"${{ parameters.proxyUrl }}/Admin/IsAlive`" | Out-Null"
Invoke-WebRequest -Uri "${{ parameters.proxyUrl }}/Admin/IsAlive" | Out-Null
- Files reviewed: 2/2 changed files
- Comments generated: 2
|
The following pipelines have been queued for testing: |
|
|
|
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#15500 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Scott Beddall <scbedd@microsoft.com>
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#15500 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Scott Beddall <scbedd@microsoft.com>
See title. Based on follow-up discussion with @heaths