Skip to content

Allow targeting of a URL in proxy template#15500

Merged
scbedd merged 2 commits into
mainfrom
allow-https-binding
May 7, 2026
Merged

Allow targeting of a URL in proxy template#15500
scbedd merged 2 commits into
mainfrom
allow-https-binding

Conversation

@scbedd
Copy link
Copy Markdown
Member

@scbedd scbedd commented May 5, 2026

See title. Based on follow-up discussion with @heaths

@scbedd scbedd self-assigned this May 5, 2026
Copilot AI review requested due to automatic review settings May 5, 2026 19:37
@scbedd scbedd requested a review from a team as a code owner May 5, 2026 19:37
@scbedd scbedd moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 🚀🌒🧑‍🚀 May 5, 2026
Copy link
Copy Markdown
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking despite my question because maybe it's fine. Just not expected since the diff was unexpected.

Comment thread eng/common/testproxy/test-proxy-standalone-tool.yml Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the shared test-proxy pipeline templates so callers can override the proxy bind URL instead of always using the default localhost:5000 endpoint.

Changes:

  • Adds a new proxyUrl parameter to both common test-proxy templates.
  • Passes proxyUrl through to the proxy startup command via start ... -- --urls.
  • Switches the post-start Admin/IsAlive probe to use the configured URL.
Show a summary per file
File Description
eng/common/testproxy/test-proxy-tool.yml Adds configurable proxy URL support to the standard test-proxy template for startup and health checks.
eng/common/testproxy/test-proxy-standalone-tool.yml Mirrors the same configurable proxy URL behavior in the standalone test-proxy template.

Copilot's findings

Comments suppressed due to low confidence (2)

eng/common/testproxy/test-proxy-tool.yml:110

  • --urls accepts ASP.NET-style bind strings such as http://localhost:9000;https://localhost:9001 and wildcard hosts like http://0.0.0.0:0, but this readiness check treats proxyUrl as a single client URL by appending /Admin/IsAlive. Those valid bind values produce an invalid or unroutable probe URI, so the template can fail even when the proxy starts successfully.
                Write-Host "Invoke-WebRequest -Uri `"${{ parameters.proxyUrl }}/Admin/IsAlive`" | Out-Null"
                Invoke-WebRequest -Uri "${{ parameters.proxyUrl }}/Admin/IsAlive" | Out-Null

eng/common/testproxy/test-proxy-standalone-tool.yml:98

  • --urls accepts ASP.NET-style bind strings such as http://localhost:9000;https://localhost:9001 and wildcard hosts like http://0.0.0.0:0, but this readiness check treats proxyUrl as a single client URL by appending /Admin/IsAlive. Those valid bind values produce an invalid or unroutable probe URI, so the template can fail even when the proxy starts successfully.
                Write-Host "Invoke-WebRequest -Uri `"${{ parameters.proxyUrl }}/Admin/IsAlive`" | Out-Null"
                Invoke-WebRequest -Uri "${{ parameters.proxyUrl }}/Admin/IsAlive" | Out-Null
  • Files reviewed: 2/2 changed files
  • Comments generated: 2

Comment thread eng/common/testproxy/test-proxy-tool.yml Outdated
Comment thread eng/common/testproxy/test-proxy-standalone-tool.yml Outdated
@azure-sdk
Copy link
Copy Markdown
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@heaths
Copy link
Copy Markdown
Member

heaths commented May 6, 2026

net - template's Build job failed, though the rest worked. I'm kicking it to see if it works next time.

@azure-sdk
Copy link
Copy Markdown
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

scbedd added a commit to Azure/azure-sdk-for-js that referenced this pull request May 7, 2026
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#15500 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Scott Beddall <scbedd@microsoft.com>
scbedd added a commit to Azure/azure-sdk-for-rust that referenced this pull request May 7, 2026
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#15500 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Scott Beddall <scbedd@microsoft.com>
@scbedd scbedd merged commit 577fac9 into main May 7, 2026
7 checks passed
@scbedd scbedd deleted the allow-https-binding branch May 7, 2026 17:29
@kurtzeborn kurtzeborn moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 🚀🌒🧑‍🚀 May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

5 participants