Repository navigation
Delete unused azure_identity::timeout module - #2527
Merged
Merged
Conversation
github-project-automation
Bot
moved this to Untriaged
in Azure Identity SDK Improvements
Collaborator
|
API change check API changes are not detected in this pull request. |
Charles Lowell (chlowell)
marked this pull request as ready for review
April 28, 2025 20:12
Charles Lowell (chlowell)
requested review from
Larry Osterman (LarryOsterman),
Rick Winter (RickWinter) and
Heath Stewart (heaths)
as code owners
April 28, 2025 20:12
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the unused azure_identity::timeout module that was previously used for handling custom timeout behavior for DefaultAzureCredential, which has now been deprecated.
- Removed the entire timeout.rs file.
- Removed the module declaration from lib.rs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/identity/azure_identity/src/timeout.rs | Complete removal of unused timeout functionality. |
| sdk/identity/azure_identity/src/lib.rs | Removed the outdated "timeout" module reference. |
Heath Stewart (heaths)
approved these changes
Apr 28, 2025
Heath Stewart (heaths)
left a comment
Heath Stewart (heaths)
left a comment
Member
There was a problem hiding this comment.
Larry Osterman (@LarryOsterman) this or something like it you might want to consider for the AsyncRuntime you're considering.
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure Identity SDK Improvements
Larry Osterman (LarryOsterman)
approved these changes
Apr 28, 2025
github-project-automation
Bot
moved this from In Progress
to Done
in Azure Identity SDK Improvements
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2281. Appears this was added to support special DefaultAzureCredential behavior when requesting tokens from IMDS. That feature's since been removed and I don't expect to restore it.