-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update to latest version 2023-10-31 #45151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vidyashreebn
wants to merge
22
commits into
main
Choose a base branch
from
dev/digitaltwins/vidyashreeb/update-to-2023-10-31
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,127
−158
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
dc60072
Update to latest version 2023-10-31
Vidyashreebn 5450906
Update to latest version 2023-10-31
Vidyashreebn 07e1d2e
resolve compilation error
Vidyashreebn 0192362
update version and java doc
Vidyashreebn a62453c
update changelog.md
Vidyashreebn 38c751e
update changelog.md
Vidyashreebn 95a15f8
update changelog
Vidyashreebn 9cd214f
add javadocs
Vidyashreebn 2c518d4
add javadocs
Vidyashreebn 4e92dff
update asset.json
Vidyashreebn 752f822
update session records
Vidyashreebn f15852e
update asset.json
Vidyashreebn 73d5d68
update asset.json
Vidyashreebn f489988
remove imports
Vidyashreebn b6f9929
remove imports
Vidyashreebn 3fce130
mvn spotless:apply
Vidyashreebn 0cb71e1
remove imports
Vidyashreebn 16fce34
mvn spotless:apply
Vidyashreebn 93e74df
update test
Vidyashreebn 3dbb979
update assets.json
Vidyashreebn ad3ba37
remove session records
Vidyashreebn 210951b
update assets.json
Vidyashreebn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 2023-10-31 a preview API version? If not, the corresponding SDK should be a GA SDK. Let's make the current version 1.5.0, and the next version 1.6.0-beta.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I don't understand. Isn't the below convention we follow?
com.azure:azure-digitaltwins-core;< previous version > < current version >
2023-10-31 is not a preview version. The existing version is 1.5.0-beta.1 and as per https://azure.github.io/azure-sdk/java_introduction.html#versioning, I just increased minor version i.e., 1.6.0 Isn't that's what we want to do?