-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update to latest version 2023-10-31 #45151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update to latest version 2023-10-31 #45151
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
API change check APIView has identified API level changes in this PR and created following API reviews. |
@@ -118,7 +118,7 @@ com.azure:azure-data-tables;12.5.3;12.6.0-beta.1 | |||
com.azure:azure-data-tables-perf;1.0.0-beta.1;1.0.0-beta.1 | |||
com.azure:azure-developer-devcenter;1.0.8;1.1.0-beta.1 | |||
com.azure:azure-developer-loadtesting;1.0.22;1.1.0-beta.1 | |||
com.azure:azure-digitaltwins-core;1.4.2;1.5.0-beta.1 | |||
com.azure:azure-digitaltwins-core;1.5.0-beta.1;1.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 2023-10-31 a preview API version? If not, the corresponding SDK should be a GA SDK. Let's make the current version 1.5.0, and the next version 1.6.0-beta.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I don't understand. Isn't the below convention we follow?
com.azure:azure-digitaltwins-core;
2023-10-31 is not a preview version. The existing version is 1.5.0-beta.1 and as per https://azure.github.io/azure-sdk/java_introduction.html#versioning, I just increased minor version i.e., 1.6.0 Isn't that's what we want to do?
@@ -1,6 +1,11 @@ | |||
# Release History | |||
|
|||
## 1.5.0-beta.1 (Unreleased) | |||
## 1.6.0 (2025-05-01) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you use the prepare release tool for these changes. Generally, you want to use this after you've checked in your changes and just before a release. That will set up the repo accordingly.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines