Skip to content

Conversation

@dzver
Copy link
Member

@dzver dzver commented Dec 7, 2022

Proposed Changes

This reenables the livechat cancellation solution that was disabled due to Happiness concerns.

livechat_solution was not enabled as a feature and I was presented with an option to either change the if in multiple places or add it as a feature. I decided to add it as a feature.

Testing Instructions

  1. Before moving to the p2 with steps for testing with Happychat HUD, keep in mind that in order to see the step, you may need to try a little different cancellation options than what's described in the post. Come back here after completing step 2
  2. In order to start livechat, you'll have to follow the steps from pebzTe-sj-p2
  3. Make sure Missing Features/Themes shows this:

Screenshot 2022-12-07 at 11 23 55

  1. Clicking it starts live chat like this

Screenshot 2022-12-07 at 11 24 19

Pre-merge Checklist

  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Related to #

It was disabled due to Happiness concerns.

livechat_solution was not enabled as a feature and I was presented with
an option to either change the if in multiple places or add it as a
feature. I decided to add it as a feature.
@dzver dzver requested review from a team and ddc22 December 7, 2022 09:31
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 7, 2022
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@dzver dzver merged commit a7a621e into trunk Dec 7, 2022
@dzver dzver deleted the update/enable-live-chat-solution-and-fix-feature branch December 7, 2022 10:36
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants