fix: Updates prompt when previously selected list is unavailable#2002
fix: Updates prompt when previously selected list is unavailable#2002
Conversation
Removes an unnecessary comma from the prompt displayed when a previously selected list is no longer available.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #2002 +/- ##
=========================================
Coverage 24.72% 24.72%
Complexity 2932 2932
=========================================
Files 51 51
Lines 10389 10389
=========================================
Hits 2569 2569
Misses 7820 7820 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
miguelpeixe
left a comment
There was a problem hiding this comment.
Whoops, we also need that change in line 309 of src/blocks/subscribe/edit.js
|
Isn't plural the correct form here? It's the subscription lists settings.. |
But we can choose only one list? Maybe a complete rewrite is needed — from "Please, revise the subscription list selection" to "Please select a list". |
No, you can select more than one |
All Submissions:
Changes proposed in this Pull Request:
Removes an unnecessary comma, and changes a plural noun to individual, in the prompt displayed when a previously selected list is no longer available.
How to test the changes in this Pull Request:
/wp-admin/edit.php?post_type=newspack_nl_cpt&page=newspack-newsletters-settings-adminOther information: