Skip to content

fix: Updates prompt when previously selected list is unavailable#2002

Open
gamebits wants to merge 2 commits intotrunkfrom
fix/prompt-comma
Open

fix: Updates prompt when previously selected list is unavailable#2002
gamebits wants to merge 2 commits intotrunkfrom
fix/prompt-comma

Conversation

@gamebits
Copy link
Copy Markdown

All Submissions:

Changes proposed in this Pull Request:

Removes an unnecessary comma, and changes a plural noun to individual, in the prompt displayed when a previously selected list is no longer available.

How to test the changes in this Pull Request:

  1. Insert a Newsletter Subscription Form block without having selected a list.
  2. Navigate to /wp-admin/edit.php?post_type=newspack_nl_cpt&page=newspack-newsletters-settings-admin
  3. Select a list
  4. Reload the post editor with the form block.
  5. Observe the warning message:
A previously selected list is no longer available. Please, revise the subscription list selection.

please-revise

  1. Merge this branch.
  2. Observe the warning message:
A previously selected list is no longer available. Please revise the subscription list selection.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Ken Gagne added 2 commits December 19, 2025 13:47
Removes an unnecessary comma from the prompt displayed when a previously selected list is no longer available.
@gamebits gamebits requested a review from a team as a code owner December 19, 2025 18:51
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24.72%. Comparing base (9212a3b) to head (4a8a1f2).

Additional details and impacted files
@@            Coverage Diff            @@
##              trunk    #2002   +/-   ##
=========================================
  Coverage     24.72%   24.72%           
  Complexity     2932     2932           
=========================================
  Files            51       51           
  Lines         10389    10389           
=========================================
  Hits           2569     2569           
  Misses         7820     7820           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Ken!

Copy link
Copy Markdown
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, we also need that change in line 309 of src/blocks/subscribe/edit.js

@leogermani
Copy link
Copy Markdown
Contributor

Isn't plural the correct form here? It's the subscription lists settings..

@gamebits
Copy link
Copy Markdown
Author

Isn't plural the correct form here? It's the subscription lists settings..

But we can choose only one list?

Maybe a complete rewrite is needed — from "Please, revise the subscription list selection" to "Please select a list".

@leogermani
Copy link
Copy Markdown
Contributor

Isn't plural the correct form here? It's the subscription lists settings..

But we can choose only one list?

Maybe a complete rewrite is needed — from "Please, revise the subscription list selection" to "Please select a list".

No, you can select more than one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants