-
Notifications
You must be signed in to change notification settings - Fork 817
Block Delimiter: add package contents #43648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
The package requires PHP 7.2, which does not support them.
cf1e56b
to
496620a
Compare
It is no longer used
Code Coverage SummaryCoverage changed in 1 file.
Coverage check overridden by
I don't care about code coverage for this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR brings in the contents of the package from its original class on WordPress.com while addressing PHPCS warnings and PHP version compatibility. Key changes include removing the version-constants block from composer.json, addressing PHPCS warnings, and adding an initial changelog file for the new functionality.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
projects/packages/block-delimiter/composer.json | Removed the "version-constants" field to support PHP 7.2 usage. |
projects/packages/block-delimiter/changelog/add-block-delimiter-contents | Added a changelog entry for the new package content integration. |
Comments suppressed due to low confidence (1)
projects/packages/block-delimiter/composer.json:50
- The removal of the 'version-constants' block might affect how the package version is automatically injected. Verify that consumers of the package will not be adversely impacted by this change in version management.
"textdomain": "jetpack-block-delimiter"
Following #43648, we can start using the new class to parse blocks. Internal reference: p7H4VZ-5l1-p2
Following #43648, we can start using the new class to parse blocks. Internal reference: p7H4VZ-5l1-p2
Since the class does not rely on WordPress, we can afford to be more permissive, and not necessarily stick to WordPress coding standards. This reverts some of the changes made in #43648.
* Block delimiter: update class to be closer to original codebase Since the class does not rely on WordPress, we can afford to be more permissive, and not necessarily stick to WordPress coding standards. This reverts some of the changes made in #43648. * Add changelog * Update Phan baseline to avoid errors * Update phpcs config to avoid warnings * Ignore more rules to match original file * Update readme to clarify coding standards
Proposed changes:
Following #43645, this brings the contents of the package from its original class on WordPress.com.
In order to do that, I've also had to make a few changes:
I also added a first set of tests for this new class. See ed7ae1b
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Since the package is not yet required by our plugin, we cannot see it in action. For now, tests should be enough.