Skip to content

Block delimiter: update class to be closer to original codebase #43683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 29, 2025

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented May 29, 2025

Proposed changes:

Since the class does not rely on WordPress, we can afford to be more permissive, and not necessarily stick to WordPress coding standards.

This reverts some of the changes made in #43648.

It also updates PHPCS and Phan configuration to allow for errors.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • p7H4VZ-5l1-p2#comment-12802
  • 184026-ghe-Automattic/wpcom#pullrequestreview-349166

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

This should not impact functionality. Tests should continue to pass. There should be no PHPCS or Phan errors.

jeherve added 4 commits May 29, 2025 14:42
Since the class does not rely on WordPress, we can afford to be more permissive, and not necessarily stick to WordPress coding standards.

This reverts some of the changes made in #43648.
@jeherve jeherve self-assigned this May 29, 2025
@jeherve jeherve changed the title update/block delimiter phpcs phan rules Block delimiter: update class to be closer to original codebase May 29, 2025
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link

jp-launch-control bot commented May 29, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/block-delimiter/src/class-block-delimiter.php 208/275 (75.64%) -13.30% 39 💔

Full summary · PHP report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@jeherve jeherve added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label May 29, 2025
@github-actions github-actions bot added the Docs label May 29, 2025
@jeherve jeherve merged commit 1263e48 into trunk May 29, 2025
66 checks passed
@jeherve jeherve deleted the update/block-delimiter-phpcs-phan-rules branch May 29, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant