The Witness: Use entity IDs as location IDs directly

[NewSoupVi]

Nowadays that we have per-game IDs, making the distinction between entity IDs and location IDs no longer makes sense.

This greatly reduces the size of a Witness slot's slot_data by removing the conversion dict from one to the other.

Changes:

• Removed all location IDs from the WitnessLogic*.txt files
• Replaced every reference to a location ID with the entity ID
• Reference entity IDs as ints instead of strs whereever possible, rename everything called "_hex" to "_id"
• Change the untyped entity dict to an EntityDefinition dataclass

New client: https://github.com/NewSoupVi/The-Witness-Randomizer-for-Archipelago/releases/tag/9.0.0p1

Probably needs more testing (like seed comparisons and mypy checking)

[nicholassaylor]

Looked through all of the files except player_logic.py. None of the code stood out as an issue to me. Data files seem to be accurately converted to exclude the old AP numbers.

Did not check other files for potentially missing references nor any now unused values or functions. One small comment on a value within the files, otherwise everything I looked over seems fine.

Did not test generation

[nicholassaylor]

Any reason to keep ID_START if cross-game ID conflicts are no longer an issue?

[NewSoupVi]

Since items are not changing, I see no reason to disturb their IDs atm

[NewSoupVi]

Like yes I could also change the ID of the Dots item from 158010 to 10 or whatever, but I guess like... I don't really see a need, since the item IDs are already completely arbitrary. It just means I have to make another breaking / backwards compatible client change

[nicholassaylor]

Fair