Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved packaging #31

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions .babelrc

This file was deleted.

3 changes: 2 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
index.js
lib/
dist/
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,6 @@ npm-debug.log*

# Dependency directories
node_modules/

lib/
dist/
12 changes: 8 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,23 +1,27 @@
# Changelog
## 1.4.0 / 27th Mar 2020
* Fix type errors when using `shouldRefresh=true`
* Fix prop type warning by supporting case when slots contains an array
with single string

## 1.3.0 / 9 Jul 2019

* Use the state to control and pass advertising
* window.requestBids added 2 new options:
* window.requestBids added 2 new options:
data passed via config.dataPrebid
sizeMappings (based on the gpt size mapping)
* Provider changes to use getDerivedStateFromProps to control if the component should reload (componentDidUpdate)
* Config.singleRequest to enable singleRequest for ads refresh (false by default).
* Provider props.shouldRefresh (false by default) to control if ads should be reload
when the config file is edited. All ads will be refreshed. Not option know to control
* Provider props.shouldRefresh (false by default) to control if ads should be reload
when the config file is edited. All ads will be refreshed. Not option know to control
which slot will be enable on Prebid or refresh. future release planend to add 2 new options:
config.slot.enablePrebid and config.slot.enableRefresh
* Example app.js and config.js have been edited

## 1.2.1 / 9 Oct 2018

* Rubicon Demand Manager tool has been added.
* window.requestBids has been replace with window.pbjs.rp.requestBids that will create a request
* window.requestBids has been replace with window.pbjs.rp.requestBids that will create a request
using a regex mapping between the DFP slot and the one hosted on prebid.js file hosted by Rubicon
config file doesn't need to have prebid bidders details anymore, just the details about DFP slots
* Provider has been updated if the component is reload (componentDidUpdate)
Expand Down
19 changes: 5 additions & 14 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
**This repo is based on the (great job) done by Ebay on: https://github.com/technology-ebay-de/react-prebid**

**As a Rubicon employee, I have adapted it to make it work with Rubicon demand manager product**

**Do notice, it is NOT an official Rubicon product and Rubicon Project could not be liable for any use of this package**

**Please contact me for any further details or help on this package: [email protected]**

# react-prebid

A JavaScript library for ad placements with [Prebid](http://prebid.org) header bidding in [React](https://reactjs.org) applications.
Expand All @@ -18,9 +12,6 @@ A JavaScript library for ad placements with [Prebid](http://prebid.org) header b
* Works well in single page applications with multiple routes
* Suitable for server-side-rendering

[![Build Status](https://travis-ci.org/AntoineJac/react-prebid-rubicon.svg?branch=master)](https://travis-ci.org/AntoineJac/react-prebid-rubicon)
[![Coverage Status](https://coveralls.io/repos/github/AntoineJac/react-prebid-rubicon/badge.svg)](https://coveralls.io/github/AntoineJac/react-prebid-rubicon)

## Prerequisites

To use *react-prebid*, you need to have a [Doubleclick for Publishers](https://www.google.com/intl/en/doubleclick/publishers/welcome/)
Expand All @@ -40,11 +31,11 @@ The demo uses the same test Prebid configuration as the

You can find documentation on how to use this library in the project's wiki:

* [Usage](https://github.com/AntoineJac/react-prebid-rubicon/wiki/Usage)
* [API](https://github.com/AntoineJac/react-prebid-rubicon/wiki/API)
* [Configuration](https://github.com/AntoineJac/react-prebid-rubicon/wiki/Configuration)
* [Custom Events](https://github.com/AntoineJac/react-prebid-rubicon/wiki/Custom-Events)
* [Plugins](https://github.com/AntoineJac/react-prebid-rubicon/wiki/Plugins)
* [Usage](https://github.com/technology-ebay-de/react-prebid/react-prebid-rubicon/wiki/Usage)
* [API](https://github.com/technology-ebay-de/react-prebid/react-prebid-rubicon/wiki/API)
* [Configuration](https://github.com/technology-ebay-de/react-prebid/react-prebid-rubicon/wiki/Configuration)
* [Custom Events](https://github.com/technology-ebay-de/react-prebid/react-prebid-rubicon/wiki/Custom-Events)
* [Plugins](https://github.com/technology-ebay-de/react-prebid/react-prebid-rubicon/wiki/Plugins)

## License

Expand Down
19 changes: 19 additions & 0 deletions babel.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
module.exports = {
presets: [
[
'@babel/preset-env',
{
targets: {
node: 'current'
}
}
],
'@babel/preset-react'
],
plugins: ['@babel/plugin-proposal-object-rest-spread', '@babel/plugin-transform-runtime'],
env: {
production: {
plugins: ['transform-react-remove-prop-types']
}
}
};
5 changes: 0 additions & 5 deletions index-esnext.js

This file was deleted.

1 change: 0 additions & 1 deletion index.js

This file was deleted.

Loading