Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved packaging #31

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Conversation

mattcolman
Copy link

This is taken straight from the original KijijiCA/react-advertising#21
Also some discussion here KijijiCA/react-advertising#18

Thanks!

@frankishh
Copy link

Hi @AntoineJac , Matt and I recently made some change to improve Code Packaging and Delivery in this PR, any chance if you could review the change, thanks heaps

@AntoineJac
Copy link
Owner

Hi @mattcolman and @frankishh , thank you for your PR and details.
I am unfortunately not working for Rubicon anymore. However I added a quick look at your PR and some edits seems specific to Domain. This project is used by several other companies, I would suggest then to copy this git and make the changes directly into your organisation folder.

Let me know if you have any questions,

Thanks,

Antoine Jacquemin

@mattcolman
Copy link
Author

Hey @AntoineJac , only the package name is Domain specific. We can change that back if you want to merge.
Do you expect to do any more updates to this package? Or do you think it's a read-only repo from here?

@AntoineJac
Copy link
Owner

AntoineJac commented Jan 19, 2020

Hi @mattcolman, yes please edit the package name and I ll merge it.
For the moment I have not planned to work on any updates on this project but worth to check with Rubicon if they have any update on this.
Thanks,

Antoine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants