-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved packaging #31
base: master
Are you sure you want to change the base?
Conversation
chore: new build script proposal
test: update unit tests and jest babel setup
Hi @AntoineJac , Matt and I recently made some change to improve Code Packaging and Delivery in this PR, any chance if you could review the change, thanks heaps |
Hi @mattcolman and @frankishh , thank you for your PR and details. Let me know if you have any questions, Thanks, Antoine Jacquemin |
Hey @AntoineJac , only the package name is Domain specific. We can change that back if you want to merge. |
Hi @mattcolman, yes please edit the package name and I ll merge it. Antoine |
Patch/add resetslot method
Improve release step
fix resetSlot when window.pbjs is undefined
Type error fixes for `shouldRefresh=true` and support new prop type option
This is taken straight from the original KijijiCA/react-advertising#21
Also some discussion here KijijiCA/react-advertising#18
Thanks!