Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(area): move area command creation #2322

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
+405 −306
Open

feat(area): move area command creation #2322

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
69febee
fix(area): rename area service
TheoPascoli Jan 28, 2025
0636b9b
feat(area): add a move_area command
TheoPascoli Jan 29, 2025
b8e41b7
fix(area): rename area service
TheoPascoli Jan 28, 2025
4190428
feat(area): add a move_area command
TheoPascoli Jan 29, 2025
6ba034b
Merge remote-tracking branch 'origin/feat/move-area-command-creation'…
TheoPascoli Jan 29, 2025
ea1f96c
feat(area): rename area_name to area_id
TheoPascoli Jan 30, 2025
dc800d7
feat(area): minor fixes
TheoPascoli Jan 30, 2025
c9fcd01
feat(area): extract area objects to area model
TheoPascoli Jan 30, 2025
f8f1570
feat(load): add area integration test
TheoPascoli Jan 30, 2025
2040a93
Merge remote-tracking branch 'origin/dev' into feat/move-area-command…
TheoPascoli Jan 30, 2025
e6b6743
feat(load): minor fix
TheoPascoli Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions antarest/study/storage/variantstudy/model/command/move_area.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

class MoveArea(ICommand):
"""
Command used to move an area in the study.
Command used to move an area inside the map and to update its UI.
TheoPascoli marked this conversation as resolved.
Show resolved Hide resolved
"""

# Overloaded metadata
Expand All @@ -42,13 +42,7 @@ class MoveArea(ICommand):

@override
def _apply_config(self, study_data: FileStudyTreeConfig) -> t.Tuple[CommandOutput, t.Dict[str, t.Any]]:
return (
CommandOutput(
status=True,
message=f"area '{self.area_id}' updated",
),
{},
)
return CommandOutput(status=True, message=f"area '{self.area_id}' UI updated"), {}

@override
def _apply(self, study_data: FileStudy, listener: t.Optional[ICommandListener] = None) -> CommandOutput:
Expand Down
Loading