Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(area): move area command creation #2322

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

feat(area): move area command creation #2322

wants to merge 11 commits into from
+405 −306

Conversation

TheoPascoli
Copy link
Contributor

add a command to move an area on the map. Replace multiple UpdateConfig commands

MartinBelthle
MartinBelthle requested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@MartinBelthle MartinBelthle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add unit test for this command as we only have one currently.

antarest/study/storage/variantstudy/model/command/move_area.py Outdated Show resolved Hide resolved
antarest/study/storage/variantstudy/model/command/move_area.py Outdated Show resolved Hide resolved
antarest/study/storage/variantstudy/model/command/move_area.py Outdated Show resolved Hide resolved
antarest/study/storage/variantstudy/model/command/move_area.py Outdated Show resolved Hide resolved
maugde
maugde reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@maugde maugde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to me

MartinBelthle
MartinBelthle requested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@MartinBelthle MartinBelthle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be nice to add a unit test on the command

antarest/study/business/area_management.py Outdated Show resolved Hide resolved
antarest/study/business/model/area_model.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maugde maugde maugde left review comments

@smailio smailio Awaiting requested review from smailio

@MartinBelthle MartinBelthle Awaiting requested review from MartinBelthle

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheoPascoli @MartinBelthle @maugde