Skip to content

Migrate to tsdown #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 20, 2025
Merged

Migrate to tsdown #25

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06c2ec3
refactor: migrate to tsdown
lishaduck Apr 20, 2025
7a3de7c
feat: update package.json scripts, modify tsconfig for module preserv…
AndreaPontrandolfo Apr 20, 2025
b8ed605
chore: removed tsup
AndreaPontrandolfo Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,18 @@
"typecheck": "tsc",
"lint": "eslint",
"knip": "knip",
"publint": "publint",
"test:watch": "vitest --ui",
"test": "vitest run",
"attw": "attw --pack .",
"qa": "pnpm typecheck && pnpm test && pnpm knip && pnpm publint && attw",
"qa": "pnpm typecheck && pnpm test && pnpm knip && attw",
"nuke": "rm -rf node_modules pnpm-lock.yaml",
"update:eslint-docs": "eslint-doc-generator",
"lint:eslint-docs": "pnpm update:eslint-docs -- --check",
"semantic-release": "pnpm build && semantic-release"
},
"files": [
"README.md",
"LICENSE",
"dist",
"docs"
],
Expand Down
2 changes: 1 addition & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { ESLint } from "eslint";
import { last } from "lodash-es";
import * as packageJson from "../package.json";
import packageJson from "../package.json";
import { rules } from "./rules";

const plugin = {
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
"include": [
"src/**/*",
"tests/**/*",
"./tsup.config.ts",
"./tsdown.config.ts",
"./vitest.config.ts",
".eslint-doc-generatorrc.mjs"
],
"compilerOptions": {
"target": "ESNext",
"lib": ["esnext"],
"composite": false,
"module": "ESNext",
"module": "preserve",
"moduleResolution": "bundler",
"sourceMap": true,
"declaration": true,
Expand Down
4 changes: 1 addition & 3 deletions tsdown.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,9 @@ import { defineConfig } from "tsdown";
export default defineConfig({
entry: ["./src/index.ts"],
format: ["esm", "cjs"],
target: "node20",
platform: "node",
clean: true,
sourcemap: false,
skipNodeModulesBundle: true,
shims: true,
Copy link
Contributor Author

@lishaduck lishaduck Apr 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't needed.
Needing shims is a sign that the bundle config is wrong.

Copy link
Owner

@AndreaPontrandolfo AndreaPontrandolfo Apr 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok but they say they strip it away if it's not used.

Copy link
Contributor Author

@lishaduck lishaduck Apr 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ehh, that's true.
I'd still prefer to get warning signs if we're doing it wrong, but it's up to you ig.

Copy link
Contributor Author

@lishaduck lishaduck Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I meant to mention, shims are good here. I forgot it isn't ESM only (although I don't see why not to go ESM-only here).

publint: { strict: true },
dts: true,
});