Migrate to tsdown #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation, and adjust tsdown configuration
lishaduck
commented
Apr 20, 2025
| clean: true, | ||
| sourcemap: false, | ||
| skipNodeModulesBundle: true, | ||
| shims: true, |
Contributor
Author
There was a problem hiding this comment.
This isn't needed.
Needing shims is a sign that the bundle config is wrong.
There was a problem hiding this comment.
ok but they say they strip it away if it's not used.
Contributor
Author
There was a problem hiding this comment.
Ehh, that's true.
I'd still prefer to get warning signs if we're doing it wrong, but it's up to you ig.
Contributor
Author
There was a problem hiding this comment.
Oh, I meant to mention, shims are good here. I forgot it isn't ESM only (although I don't see why not to go ESM-only here).
lishaduck
commented
Apr 20, 2025
| "publint": "^0.3.10", | ||
| "semantic-release": "^24.0.0", | ||
| "tsdown": "^0.9.1", | ||
| "tsup": "^8.4.0", |
Contributor
Author
There was a problem hiding this comment.
I forgot that 🤦♂️ lol
AndreaPontrandolfo
approved these changes
Apr 20, 2025
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like AndreaPontrandolfo/sheriff#390.
Closes #24.