Skip to content

fix(#2553): remove config with no properties + support metadata check for config without properties #13397

fix(#2553): remove config with no properties + support metadata check for config without properties

fix(#2553): remove config with no properties + support metadata check for config without properties #13397

GitHub Actions / IT Tests report-ubuntu-latest-npm- failed Dec 30, 2024 in 1s

62 passed, 3 failed and 2 skipped

Tests failed

Report Passed Failed Skipped Time
@ama-sdk/create/dist-test/it-report.xml 7✅ 570s
@ama-sdk/schematics/dist-test/it-report.xml 4ms
@o3r/analytics/dist-test/it-report.xml 2✅ 130s
@o3r/apis-manager/dist-test/it-report.xml 1✅ 56s
@o3r/application/dist-test/it-report.xml 1✅ 58s
@o3r/components/dist-test/it-report.xml 5✅ 3❌ 355s
@o3r/configuration/dist-test/it-report.xml 2✅ 122s
@o3r/core/dist-test/it-report.xml 1✅ 454s
@o3r/create/dist-test/it-report.xml 3✅ 329s
@o3r/design/dist-test/it-report.xml 1✅ 63s
@o3r/eslint-config-otter/dist-test/it-report.xml 2✅ 130s
@o3r/eslint-config/dist-test/it-report.xml 3✅ 377s
@o3r/extractors/dist-test/it-report.xml 3✅ 257s
@o3r/localization/dist-test/it-report.xml 8✅ 504s
@o3r/new-version/dist-test/it-report.xml 1✅ 53s
@o3r/pipeline/dist-test/it-report.xml 2✅ 70s
@o3r/rules-engine/dist-test/it-report.xml 2✅ 144s
@o3r/stylelint-plugin/dist-test/it-report.xml 2✅ 111s
@o3r/styling/dist-test/it-report.xml 8✅ 492s
@o3r/testing/dist-test/it-report.xml 2✅ 2⚪ 181s
@o3r/third-party/dist-test/it-report.xml 1✅ 65s
@o3r/workspace/dist-test/it-report.xml 5✅ 430s

✅ @ama-sdk/create/dist-test/it-report.xml

7 tests were completed in 570s with 7 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Create new sdk command 7✅ 558s

✅ Create new sdk command

Create new sdk command should generate a light SDK when the specification is provided
  ✅ Create new sdk command should generate a light SDK when the specification is provided
Create new sdk command should generate a full SDK when the specification is provided
  ✅ Create new sdk command should generate a full SDK when the specification is provided
Create new sdk command should generate a full SDK when the specification is provided as npm dependency
  ✅ Create new sdk command should generate a full SDK when the specification is provided as npm dependency
Create new sdk command should generate an SDK with no package scope
  ✅ Create new sdk command should generate an SDK with no package scope
Create new sdk command should generate an empty SDK ready to be used
  ✅ Create new sdk command should generate an empty SDK ready to be used
Create new sdk command should fail when there is an error
  ✅ Create new sdk command should fail when there is an error
Create new sdk command should use pinned versions when --exact-o3r-version is used
  ✅ Create new sdk command should use pinned versions when --exact-o3r-version is used

✅ @ama-sdk/schematics/dist-test/it-report.xml

No tests found

✅ @o3r/analytics/dist-test/it-report.xml

2 tests were completed in 130s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
ng add analytics 2✅ 117s

✅ ng add analytics

ng add analytics should add analytics to an application
  ✅ ng add analytics should add analytics to an application
ng add analytics should add analytics to a library
  ✅ ng add analytics should add analytics to a library

✅ @o3r/apis-manager/dist-test/it-report.xml

1 tests were completed in 56s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
new otter application with apis-manager 1✅ 46s

✅ new otter application with apis-manager

new otter application with apis-manager should add apis-manager to existing application
  ✅ new otter application with apis-manager should add apis-manager to existing application

✅ @o3r/application/dist-test/it-report.xml

1 tests were completed in 58s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
new Angular application 1✅ 46s

✅ new Angular application

new Angular application should add Otter Application to existing Angular app
  ✅ new Angular application should add Otter Application to existing Angular app

❌ @o3r/components/dist-test/it-report.xml

8 tests were completed in 355s with 5 passed, 3 failed and 0 skipped.

Test suite Passed Failed Skipped Time
check metadata migration 3✅ 3❌ 344s
ng add components 2✅ 198s

❌ check metadata migration

check metadata migration should not throw
  ✅ check metadata migration should not throw
check metadata migration should not throw on prerelease
  ✅ check metadata migration should not throw on prerelease
check metadata migration should throw because no migration data
  ❌ check metadata migration should throw because no migration data
	Error: expect(received).toContain(expected) // indexOf
check metadata migration should throw because migration data invalid
  ❌ check metadata migration should throw because migration data invalid
	Error: expect(received).toContain(expected) // indexOf
check metadata migration should throw because breaking changes are not allowed
  ❌ check metadata migration should throw because breaking changes are not allowed
	Error: expect(received).toContain(expected) // indexOf
check metadata migration should throw because of unused migration data
  ✅ check metadata migration should throw because of unused migration data

✅ ng add components

ng add components should add components to an application
  ✅ ng add components should add components to an application
ng add components should add components to a library
  ✅ ng add components should add components to a library

✅ @o3r/configuration/dist-test/it-report.xml

2 tests were completed in 122s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
new otter application with configuration 2✅ 110s

✅ new otter application with configuration

new otter application with configuration should add configuration to an application
  ✅ new otter application with configuration should add configuration to an application
new otter application with configuration should add configuration to a library
  ✅ new otter application with configuration should add configuration to a library

✅ @o3r/core/dist-test/it-report.xml

1 tests were completed in 454s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
new otter application 1✅ 435s

✅ new otter application

new otter application should build empty app
  ✅ new otter application should build empty app

✅ @o3r/create/dist-test/it-report.xml

3 tests were completed in 329s with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Create new otter project command 3✅ 320s

✅ Create new otter project command

Create new otter project command should generate a project with an application
  ✅ Create new otter project command should generate a project with an application
Create new otter project command should generate a project with a library
  ✅ Create new otter project command should generate a project with a library
Create new otter project command should generate a project with an application with --exact-o3r-version
  ✅ Create new otter project command should generate a project with an application with --exact-o3r-version

✅ @o3r/design/dist-test/it-report.xml

1 tests were completed in 63s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
new otter application with Design 1✅ 48s

✅ new otter application with Design

new otter application with Design should add design to existing application
  ✅ new otter application with Design should add design to existing application

✅ @o3r/eslint-config-otter/dist-test/it-report.xml

2 tests were completed in 130s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
ng add eslint-config 2✅ 119s

✅ ng add eslint-config

ng add eslint-config should add eslint-config to an application
  ✅ ng add eslint-config should add eslint-config to an application
ng add eslint-config should add eslint-config to a library
  ✅ ng add eslint-config should add eslint-config to a library

✅ @o3r/eslint-config/dist-test/it-report.xml

3 tests were completed in 377s with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
new otter application with eslint config 3✅ 360s

✅ new otter application with eslint config

new otter application with eslint config should add eslint config to existing application
  ✅ new otter application with eslint config should add eslint config to existing application
new otter application with eslint config should add eslint config to existing library
  ✅ new otter application with eslint config should add eslint config to existing library
new otter application with eslint config should add eslint config to existing repository
  ✅ new otter application with eslint config should add eslint config to existing repository

✅ @o3r/extractors/dist-test/it-report.xml

3 tests were completed in 257s with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
aggregate migration scripts 1✅ 191s
ng add extractors 2✅ 238s

✅ aggregate migration scripts

aggregate migration scripts should create migration scripts including lib content
  ✅ aggregate migration scripts should create migration scripts including lib content

✅ ng add extractors

ng add extractors should add extractors to an application
  ✅ ng add extractors should add extractors to an application
ng add extractors should add extractors to a library
  ✅ ng add extractors should add extractors to a library

✅ @o3r/localization/dist-test/it-report.xml

8 tests were completed in 504s with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
check metadata migration 6✅ 487s
ng add otter localization 2✅ 153s

✅ check metadata migration

check metadata migration should not throw
  ✅ check metadata migration should not throw
check metadata migration should not throw on prerelease
  ✅ check metadata migration should not throw on prerelease
check metadata migration should throw because no migration data
  ✅ check metadata migration should throw because no migration data
check metadata migration should throw because migration data invalid
  ✅ check metadata migration should throw because migration data invalid
check metadata migration should throw because breaking changes are not allowed
  ✅ check metadata migration should throw because breaking changes are not allowed
check metadata migration should throw because of unused migration data
  ✅ check metadata migration should throw because of unused migration data

✅ ng add otter localization

ng add otter localization should add localization to an application
  ✅ ng add otter localization should add localization to an application
ng add otter localization should add localization to a library
  ✅ ng add otter localization should add localization to a library

✅ @o3r/new-version/dist-test/it-report.xml

1 tests were completed in 53s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
undefined 1✅ 43s

✅ undefined

 should add Otter Application to existing Angular app
  ✅ should add Otter Application to existing Angular app

✅ @o3r/pipeline/dist-test/it-report.xml

2 tests were completed in 70s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
new otter project 2✅ 60s

✅ new otter project

new otter project should add a GitHub pipeline to existing project
  ✅ new otter project should add a GitHub pipeline to existing project
new otter project should add a GitHub pipeline to existing project with custom runner and registry
  ✅ new otter project should add a GitHub pipeline to existing project with custom runner and registry

✅ @o3r/rules-engine/dist-test/it-report.xml

2 tests were completed in 144s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
ng add rules-engine 2✅ 127s

✅ ng add rules-engine

ng add rules-engine should add rules engine to an application
  ✅ ng add rules-engine should add rules engine to an application
ng add rules-engine should add rules engine to a library
  ✅ ng add rules-engine should add rules engine to a library

✅ @o3r/stylelint-plugin/dist-test/it-report.xml

2 tests were completed in 111s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
ng add stylelint-plugin 2✅ 101s

✅ ng add stylelint-plugin

ng add stylelint-plugin should add stylelint-plugin to an application
  ✅ ng add stylelint-plugin should add stylelint-plugin to an application
ng add stylelint-plugin should add stylelint-plugin to a library
  ✅ ng add stylelint-plugin should add stylelint-plugin to a library

✅ @o3r/styling/dist-test/it-report.xml

8 tests were completed in 492s with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
check metadata migration 6✅ 475s
ng add styling 2✅ 165s

✅ check metadata migration

check metadata migration should not throw
  ✅ check metadata migration should not throw
check metadata migration should not throw on prerelease
  ✅ check metadata migration should not throw on prerelease
check metadata migration should throw because no migration data
  ✅ check metadata migration should throw because no migration data
check metadata migration should throw because migration data invalid
  ✅ check metadata migration should throw because migration data invalid
check metadata migration should throw because breaking changes are not allowed
  ✅ check metadata migration should throw because breaking changes are not allowed
check metadata migration should throw because of unused migration data
  ✅ check metadata migration should throw because of unused migration data

✅ ng add styling

ng add styling should add styling to an application
  ✅ ng add styling should add styling to an application
ng add styling should add styling to a library
  ✅ ng add styling should add styling to a library

✅ @o3r/testing/dist-test/it-report.xml

4 tests were completed in 181s with 2 passed, 0 failed and 2 skipped.

Test suite Passed Failed Skipped Time
ng add testing 2✅ 2⚪ 169s

✅ ng add testing

ng add testing should add testing to an application
  ✅ ng add testing should add testing to an application
ng add testing should add testing to an application and fixture to component
  ✅ ng add testing should add testing to an application and fixture to component
ng add testing should add testing to a library
  ⚪ ng add testing should add testing to a library
ng add testing should add testing to a library and fixture to component
  ⚪ ng add testing should add testing to a library and fixture to component

✅ @o3r/third-party/dist-test/it-report.xml

1 tests were completed in 65s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
new Angular application 1✅ 54s

✅ new Angular application

new Angular application should add Otter Third Party to existing Angular app
  ✅ new Angular application should add Otter Third Party to existing Angular app

✅ @o3r/workspace/dist-test/it-report.xml

5 tests were completed in 430s with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
new otter workspace 5✅ 417s

✅ new otter workspace

new otter workspace should add sdk to an existing workspace
  ✅ new otter workspace should add sdk to an existing workspace
new otter workspace should add sdk to an existing workspace with local spec
  ✅ new otter workspace should add sdk to an existing workspace with local spec
new otter workspace should add sdk to an existing workspace with spec package name
  ✅ new otter workspace should add sdk to an existing workspace with spec package name
new otter workspace should add a library to an existing workspace
  ✅ new otter workspace should add a library to an existing workspace
new otter workspace should generate a monorepo setup
  ✅ new otter workspace should generate a monorepo setup

Annotations

Check failure on line 351 in packages/@o3r/components/builders/metadata-check/index.it.spec.ts

See this annotation in the file changed.

@github-actions github-actions / IT Tests report-ubuntu-latest-npm-

check metadata migration ► check metadata migration should throw because no migration data ► check metadata migration should throw because no migration data

Failed test found in:
  @o3r/components/dist-test/it-report.xml
Error:
  Error: expect(received).toContain(expected) // indexOf
Raw output
Error: expect(received).toContain(expected) // indexOf

Expected substring: "Property @o3r/lib10#MyConfig10 has been modified but is not documented in the migration document"
Received string:    "Command failed: npm exec ng run test-app:check-metadata
STDERR:
Property @o3r/lib1#MyConfig1 prop1 has been modified but is not documented in the migration document
Property @o3r/lib2#MyConfig2 prop2 has been modified but is not documented in the migration document
Property @o3r/lib3#MyConfig3 prop3 has been modified but is not documented in the migration document
Property @o3r/lib4#MyConfig4 prop4 has been modified but is not documented in the migration document
Property @o3r/lib5#MyConfig5 prop5 has been modified but is not documented in the migration document
Property @o3r/lib6#MyConfig6 prop6 has been modified but is not documented in the migration document
Property @o3r/lib7#MyConfig7 prop7 has been modified but is not documented in the migration document
Property @o3r/lib8#MyConfig8 prop8 has been modified but is not documented in the migration document
Property @o3r/lib9#MyConfig9 prop9 has been modified but is not documented in the migration document·
OUTPUT:
,Latest version present in migration data folder: 1.3.0
Fetching @o3r/test-app-components-metadata-check2-no-migration-data@<1.3.0-a from the registry.
Successfully fetched @o3r/test-app-components-metadata-check2-no-migration-data@<1.3.0-a with version 1.2.1.
Resolved metadata from \"./component.config.metadata.json\".
,Property @o3r/lib1#MyConfig1 prop1 has been modified but is not documented in the migration document
Property @o3r/lib2#MyConfig2 prop2 has been modified but is not documented in the migration document
Property @o3r/lib3#MyConfig3 prop3 has been modified but is not documented in the migration document
Property @o3r/lib4#MyConfig4 prop4 has been modified but is not documented in the migration document
Property @o3r/lib5#MyConfig5 prop5 has been modified but is not documented in the migration document
Property @o3r/lib6#MyConfig6 prop6 has been modified but is not documented in the migration document
Property @o3r/lib7#MyConfig7 prop7 has been modified but is not documented in the migration document
Property @o3r/lib8#MyConfig8 prop8 has been modified but is not documented in the migration document
Property @o3r/lib9#MyConfig9 prop9 has been modified but is not documented in the migration document
"
    at /home/runner/work/otter/otter/packages/@o3r/components/builders/metadata-check/index.it.spec.ts:353:27
    at Array.forEach (<anonymous>)
    at Object.<anonymous> (/home/runner/work/otter/otter/packages/@o3r/components/builders/metadata-check/index.it.spec.ts:351:46)

Check failure on line 386 in packages/@o3r/components/builders/metadata-check/index.it.spec.ts

See this annotation in the file changed.

@github-actions github-actions / IT Tests report-ubuntu-latest-npm-

check metadata migration ► check metadata migration should throw because migration data invalid ► check metadata migration should throw because migration data invalid

Failed test found in:
  @o3r/components/dist-test/it-report.xml
Error:
  Error: expect(received).toContain(expected) // indexOf
Raw output
Error: expect(received).toContain(expected) // indexOf

Expected substring: "Property @o3r/lib10#MyConfig10 has been modified but the new property is not present in the new metadata"
Received string:    "Command failed: npm exec ng run test-app:check-metadata
STDERR:
Property @o3r/lib1#MyConfig1 prop1 has been modified but the new property is not present in the new metadata
Property @o3r/lib2#MyConfig2 prop2 has been modified but the new property is not present in the new metadata
Property @o3r/lib3#MyConfig3 prop3 has been modified but the new property is not present in the new metadata
Property @o3r/lib4#MyConfig4 prop4 has been modified but the new property is not present in the new metadata
Property @o3r/lib5#MyConfig5 prop5 has been modified but the new property is not present in the new metadata
Property @o3r/lib6#MyConfig6 prop6 has been modified but the new property is not present in the new metadata
Property @o3r/lib7#MyConfig7 prop7 has been modified but the new property is not present in the new metadata
Property @o3r/lib8#MyConfig8 prop8 has been modified but the new property is not present in the new metadata
Property @o3r/lib9#MyConfig9 prop9 has been modified but the new property is not present in the new metadata·
OUTPUT:
,Latest version present in migration data folder: 1.3.0
Fetching @o3r/test-app-components-metadata-check3-invalid-data@<1.3.0-a from the registry.
Successfully fetched @o3r/test-app-components-metadata-check3-invalid-data@<1.3.0-a with version 1.2.1.
Resolved metadata from \"./component.config.metadata.json\".
,Property @o3r/lib1#MyConfig1 prop1 has been modified but the new property is not present in the new metadata
Property @o3r/lib2#MyConfig2 prop2 has been modified but the new property is not present in the new metadata
Property @o3r/lib3#MyConfig3 prop3 has been modified but the new property is not present in the new metadata
Property @o3r/lib4#MyConfig4 prop4 has been modified but the new property is not present in the new metadata
Property @o3r/lib5#MyConfig5 prop5 has been modified but the new property is not present in the new metadata
Property @o3r/lib6#MyConfig6 prop6 has been modified but the new property is not present in the new metadata
Property @o3r/lib7#MyConfig7 prop7 has been modified but the new property is not present in the new metadata
Property @o3r/lib8#MyConfig8 prop8 has been modified but the new property is not present in the new metadata
Property @o3r/lib9#MyConfig9 prop9 has been modified but the new property is not present in the new metadata
"
    at /home/runner/work/otter/otter/packages/@o3r/components/builders/metadata-check/index.it.spec.ts:389:27
    at Array.forEach (<anonymous>)
    at Object.<anonymous> (/home/runner/work/otter/otter/packages/@o3r/components/builders/metadata-check/index.it.spec.ts:386:46)

Check failure on line 415 in packages/@o3r/components/builders/metadata-check/index.it.spec.ts

See this annotation in the file changed.

@github-actions github-actions / IT Tests report-ubuntu-latest-npm-

check metadata migration ► check metadata migration should throw because breaking changes are not allowed ► check metadata migration should throw because breaking changes are not allowed

Failed test found in:
  @o3r/components/dist-test/it-report.xml
Error:
  Error: expect(received).toContain(expected) // indexOf
Raw output
Error: expect(received).toContain(expected) // indexOf

Expected substring: "Property @o3r/lib10#MyConfig10 is not present in the new metadata and breaking changes are not allowed"
Received string:    "Command failed: npm exec ng run test-app:check-metadata
STDERR:
Property @o3r/lib1#MyConfig1 prop1 is not present in the new metadata and breaking changes are not allowed
Property @o3r/lib2#MyConfig2 prop2 is not present in the new metadata and breaking changes are not allowed
Property @o3r/lib3#MyConfig3 prop3 is not present in the new metadata and breaking changes are not allowed
Property @o3r/lib4#MyConfig4 prop4 is not present in the new metadata and breaking changes are not allowed
Property @o3r/lib5#MyConfig5 prop5 is not present in the new metadata and breaking changes are not allowed
Property @o3r/lib6#MyConfig6 prop6 is not present in the new metadata and breaking changes are not allowed
Property @o3r/lib7#MyConfig7 prop7 is not present in the new metadata and breaking changes are not allowed
Property @o3r/lib8#MyConfig8 prop8 is not present in the new metadata and breaking changes are not allowed
Property @o3r/lib9#MyConfig9 prop9 is not present in the new metadata and breaking changes are not allowed·
OUTPUT:
,Latest version present in migration data folder: 1.3.0
Fetching @o3r/test-app-components-metadata-check4-breaking-changes@<1.3.0-a from the registry.
Successfully fetched @o3r/test-app-components-metadata-check4-breaking-changes@<1.3.0-a with version 1.2.1.
Resolved metadata from \"./component.config.metadata.json\".
,Property @o3r/lib1#MyConfig1 prop1 is not present in the new metadata and breaking changes are not allowed
Property @o3r/lib2#MyConfig2 prop2 is not present in the new metadata and breaking changes are not allowed
Property @o3r/lib3#MyConfig3 prop3 is not present in the new metadata and breaking changes are not allowed
Property @o3r/lib4#MyConfig4 prop4 is not present in the new metadata and breaking changes are not allowed
Property @o3r/lib5#MyConfig5 prop5 is not present in the new metadata and breaking changes are not allowed
Property @o3r/lib6#MyConfig6 prop6 is not present in the new metadata and breaking changes are not allowed
Property @o3r/lib7#MyConfig7 prop7 is not present in the new metadata and breaking changes are not allowed
Property @o3r/lib8#MyConfig8 prop8 is not present in the new metadata and breaking changes are not allowed
Property @o3r/lib9#MyConfig9 prop9 is not present in the new metadata and breaking changes are not allowed
"
    at /home/runner/work/otter/otter/packages/@o3r/components/builders/metadata-check/index.it.spec.ts:419:27
    at Array.forEach (<anonymous>)
    at Object.<anonymous> (/home/runner/work/otter/otter/packages/@o3r/components/builders/metadata-check/index.it.spec.ts:415:46)