fix(#2553): remove config with no properties + support metadata check…

… for config without properties

packages/@o3r/components/builders/component-extractor/helpers/component/component.extractor.ts

@@ -276,6 +276,9 @@ export class ComponentExtractor {
         } else {
           this.logger.warn(message);
         }
+        if (propertiesWithDefaultValue.length === 0) {
+          return acc;
+        }
         const configWithoutIncompatibleProperties = {
           ...config,
           properties: propertiesWithDefaultValue

packages/@o3r/components/builders/metadata-check/helpers/config-metadata-comparison.helper.ts

@@ -35,9 +35,7 @@ export interface MigrationConfigData {
  * ```
  */
 const getConfigurationArray = (content: ComponentConfigOutput[]): ComponentConfigOutput[] => content.flatMap((config) =>
-  config.properties.length > 1
-    ? config.properties.map((prop) => ({ ...config, properties: [prop] }))
-    : [config]
+  config.properties.map((prop) => ({ ...config, properties: [prop] }))
 );
 
 const getConfigurationPropertyName = (config: ComponentConfigOutput) => `${config.library}#${config.name}` + (config.properties.length > 0 ? ` ${config.properties[0].name}` : '');

packages/@o3r/components/builders/metadata-check/index.it.spec.ts

@@ -32,8 +32,9 @@ import {
 import {
   inc,
 } from 'semver';
-import type {
-  MigrationConfigData,
+import {
+  configMetadataComparator,
+  type MigrationConfigData,
 } from './helpers/config-metadata-comparison.helper';
 import type {
   ComponentConfigOutput,
@@ -185,7 +186,10 @@ const previousConfigurationMetadata: ComponentConfigOutput[] = [
   createConfig('@o3r/lib6', 'MyConfig6', ['prop6']),
   createConfig('@o3r/lib7', 'MyConfig7', ['prop7']),
   createConfig('@o3r/lib8', 'MyConfig8', ['prop8']),
-  createConfig('@o3r/lib9', 'MyConfig9', ['prop9'])
+  createConfig('@o3r/lib9', 'MyConfig9', ['prop9']),
+  // This case should not happen anymore as we filter config without properties
+  // Adding this case to ensure the support of older metadata
+  createConfig('@o3r/lib10', 'MyConfig10', [])
 ];
 
 const newConfigurationMetadata: ComponentConfigOutput[] = [
@@ -344,8 +348,8 @@ describe('check metadata migration', () => {
     } catch (e: any) {
       /* eslint-disable jest/no-conditional-expect -- always called as there is a throw in the try block */
       expect(e.message).not.toBe('should have thrown before');
-      previousConfigurationMetadata.slice(1).forEach(({ library, name, properties }) => {
-        const id = `${library}#${name} ${properties[0].name}`;
+      previousConfigurationMetadata.slice(1).forEach((item) => {
+        const id = configMetadataComparator.getIdentifier(item);
         expect(e.message).toContain(`Property ${id} has been modified but is not documented in the migration document`);
         expect(e.message).not.toContain(`Property ${id} has been modified but the new property is not present in the new metadata`);
         expect(e.message).not.toContain(`Property ${id} is not present in the new metadata and breaking changes are not allowed`);
@@ -379,8 +383,8 @@ describe('check metadata migration', () => {
     } catch (e: any) {
       /* eslint-disable jest/no-conditional-expect -- always called as there is a throw in the try block */
       expect(e.message).not.toBe('should have thrown before');
-      previousConfigurationMetadata.slice(1).forEach(({ library, name, properties }) => {
-        const id = `${library}#${name} ${properties[0].name}`;
+      previousConfigurationMetadata.slice(1).forEach((item) => {
+        const id = configMetadataComparator.getIdentifier(item);
         expect(e.message).not.toContain(`Property ${id} has been modified but is not documented in the migration document`);
         expect(e.message).toContain(`Property ${id} has been modified but the new property is not present in the new metadata`);
         expect(e.message).not.toContain(`Property ${id} is not present in the new metadata and breaking changes are not allowed`);
@@ -408,8 +412,8 @@ describe('check metadata migration', () => {
     } catch (e: any) {
       /* eslint-disable jest/no-conditional-expect -- always called as there is a throw in the try block */
       expect(e.message).not.toBe('should have thrown before');
-      previousConfigurationMetadata.slice(1).forEach(({ library, name, properties }) => {
-        const id = `${library}#${name} ${properties[0].name}`;
+      previousConfigurationMetadata.slice(1).forEach((item) => {
+        const id = configMetadataComparator.getIdentifier(item);
         expect(e.message).not.toContain(`Property ${id} has been modified but is not documented in the migration document`);
         expect(e.message).not.toContain(`Property ${id} has been modified but the new property is not present in the new metadata`);
         expect(e.message).toContain(`Property ${id} is not present in the new metadata and breaking changes are not allowed`);

packages/@o3r/configuration/schemas/configuration.metadata.schema.json

@@ -216,7 +216,8 @@
               }
             }
           ]
-        }
+        },
+        "minItems": 1
       }
     }
   }