-
Notifications
You must be signed in to change notification settings - Fork 17
Logspace colorbar #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
e32580d
18ef34d
263c6b3
c2d0198
0876fcb
03521a7
0a81888
6ff38ed
a463c00
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -249,6 +249,7 @@ private: | |
| void DirtyFrames(); | ||
| void DoRubberBanding(Widget, XtPointer, XtPointer); | ||
| void DoBoxesButton(Widget, XtPointer, XtPointer); | ||
| void DoLogScaleButton(Widget, XtPointer, XtPointer); | ||
| void DoCGSmoothing(Widget, XtPointer, XtPointer); | ||
| void DoCGShowBody(Widget, XtPointer, XtPointer); | ||
| void DoAnimBackStep(); | ||
|
|
@@ -348,7 +349,7 @@ class AVXGrab { | |
| public: | ||
| AVXGrab(Display *display) : bIsGrabbed(true), cachedDisplay(display) { | ||
| XSync(cachedDisplay, False); | ||
| XGrabServer(display); | ||
| //XGrabServer(display); | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I need to refactor this out into a separate PR. This could be controlled by an ifdef so Amrvis will work with x11vnc or xpra.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the grab even necessary with modern hardware? As I understand it, the main reasons for grabbing the server are to prevent other windows from trying to redraw themselves while drawing over them (which shouldn't be needed here, since the rectangle is only drawn over our own widgets), and to prevent other apps from congesting the server while doing something interactive (like rubber-banding). I couldn't see any performance differences when I commented out the grab call (running on a local Xorg server). If anything, it was slightly less flickery. |
||
| XSync(cachedDisplay, False); | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This documentation update could be split into a separate PR.