Logspace colorbar #34
Conversation
The log scale toggle was previously only updating the colorbar labels but not the actual data-to-color mapping. This fix implements logarithmic transformation of data values before color mapping when log scaling is enabled. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
cc @zingale |
| AVXGrab(Display *display) : bIsGrabbed(true), cachedDisplay(display) { | ||
| XSync(cachedDisplay, False); | ||
| XGrabServer(display); | ||
| //XGrabServer(display); |
There was a problem hiding this comment.
I need to refactor this out into a separate PR. This could be controlled by an ifdef so Amrvis will work with x11vnc or xpra.
There was a problem hiding this comment.
Is the grab even necessary with modern hardware? As I understand it, the main reasons for grabbing the server are to prevent other windows from trying to redraw themselves while drawing over them (which shouldn't be needed here, since the rectangle is only drawn over our own widgets), and to prevent other apps from congesting the server while doing something interactive (like rubber-banding). I couldn't see any performance differences when I commented out the grab call (running on a local Xorg server). If anything, it was slightly less flickery.
There was a problem hiding this comment.
This documentation update could be split into a separate PR.
|
just tried it and it seems to work great. |
3 participants
This adds a log-spaced colorbar that can be toggled with the
Lkey. If any data values for the current selected variable are non-positive, it does nothing.There are two unrelated minor changes in this branch that I need to split into separate PRs before I un-draft this PR.