Skip to content

Fix Guice > 4.1 error with Rocoto module implementation #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
turnef wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Guice > 4.1 error with Rocoto module implementation #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/main/java/org/nnsoft/guice/rocoto/Rocoto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,10 @@
import com.google.inject.Module;
import com.google.inject.TypeLiteral;
import com.google.inject.name.Named;
import com.google.inject.spi.DefaultBindingTargetVisitor;
import com.google.inject.spi.DefaultElementVisitor;
import com.google.inject.spi.Element;
import com.google.inject.spi.InstanceBinding;

/**
* @since 6.0
Expand Down Expand Up @@ -95,7 +97,7 @@ public <T> Void visit( Binding<T> binding )
propertyKey = ( (javax.inject.Named) bindingKey.getAnnotation() ).value();
}

String propertyValue = (String) binding.getProvider().get();
String propertyValue = getPropertyValue((Binding<String>) binding);

variablesMap.put( propertyKey, propertyValue );
}
Expand All @@ -112,4 +114,13 @@ public <T> Void visit( Binding<T> binding )
}
}

static String getPropertyValue(Binding<String> binding) {
return binding.acceptTargetVisitor(new DefaultBindingTargetVisitor<String, String>() {

@Override
public String visit(InstanceBinding<? extends String> instanceBinding) {
return instanceBinding.getInstance();
}});
}

}