Fix Guice > 4.1 error with Rocoto module implementation #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoking the getProvider() method on an InstanceBinding in Guice versions 4.2 or later result in a runtime exception as documented in this issue: #12
This pull request addresses the issue by using a BindingTargetVisitor to interrogate the InstanceBinding and retrieve the bound String value. I'm not sure this is the best way to correct the problem, but the existing unit tests pass when linked against Guice 4.2.3 and Guava 30.1-jre, as well Guice 4.0 and Guava 18.0 as defined in the current pom.xml.