feat(pr-check): Create pr-check workflow #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should update the checks api status to 'success' on the head.sha allowing the 'checks' job to pass.
PR check combines PR title and Checks into a single workflow with dependent jobs. This achieves 2 things: 1. Checks will not run until the PR title is valid. 2. Consistent name in iac for the repository rule required check.
Required to re-request checks.
chris3ware
changed the title
|
Re-request checks run, but fails: https://github.com/3ware/workflows/actions/runs/13693673491/job/38291330720#step:7:1 |
|
I don't think we can get this to work this way. Better to push an empty commit now the logic is sound (the logic being: "run when comment is deleted") |
Replace the `gh api` run command for re-requesting checks via the checks api with an action to push an empty commit.
chris3ware
changed the title
chris3ware
changed the title
chris3ware
changed the title
chris3ware
changed the title
chris3ware
changed the title
Workflow failed because token not set.
chris3ware
force-pushed
the
feat-pr-title-recheck
branch
from
983dfb7 to
20b64ce
Compare
…ck' into feat-pr-title-recheck
chris3ware
force-pushed
the
feat-pr-title-recheck
branch
from
df31d1b to
a9e48cc
Compare
|
Empty commit has challenges too. github token loop prevention, PAT doesn't seem to work with the commit action and the logic still isn't right. Delete comments always runs, which mean the commit action will run when we don't want it to. |
github.sha in a pull requests is the merge commit
Job must finish to see check conclusion
chris3ware
changed the title
chris3ware
changed the title
Now that PR check calls this workflow the pattern to be ignored is: `Checks / auto-approve-pr`
james3ware
approved these changes
Mar 6, 2025
3ware-release bot
pushed a commit
that referenced
this pull request
Mar 6, 2025
## [4.13.0](v4.12.0...v4.13.0) (2025-03-06) ### Features * **pr-check:** Create pr-check workflow ([#172](#172)) ([9c6cac7](9c6cac7))
|
This PR is included in version 4.13.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request adds functionality to re-request checks in the pr-title workflow. Checks are re-requested if a comment, advising why the title is invalid, is deleted. This means the PR title is valid and that checks should be requested to update the status of failed pr-title checks on the head.sha - allowing all checks to pass.rerunning checks is not working - going with empty commit.The scope of this PR has changed somewhat. The logic for pushing empty commits or re-requesting checks does not work without access to the required context via
pull_request_target. See this comment: #168 (comment)This PR creates a pr-check workflow, which calls pr-title and wait-for-checks, as other repositories do to simplify the terraform for the required check on the repository ruleset.
Resolves #171