Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create pr-check workflow #171

Closed
chris3ware opened this issue Mar 5, 2025 · 3 comments · Fixed by #172
Closed

Create pr-check workflow #171

chris3ware opened this issue Mar 5, 2025 · 3 comments · Fixed by #172

Comments

@chris3ware
Copy link
Member

pr-check workflow combines pr-title and wait-for-checks in downstream repositories. Combining the jobs into a single workflow ensures pr-title succeeds before 'checks' runs removing the need for the empty commit.

This has the added benefit of the required check workflow name being the same in the iac configuration.

See https://github.com/3ware/repoman/issues/204
@chris3ware
Copy link
Member Author

To have consistent required check name between workflow repo and all calling repos an input can be used to skip running checks when called.

actions/runner#3146

@chris3ware
Copy link
Member Author

To have consistent required check name between workflow repo and all calling repos an input can be used to skip running checks when called.

actions/runner#3146

Not required. Have combined pr-title and checks into pr-check - the same as other repos. See #172

@chris3ware chris3ware mentioned this issue Mar 6, 2025
Merged
@3ware-release
Copy link
Contributor

3ware-release bot commented Mar 6, 2025

This issue has been resolved in version 4.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pr-check): Create pr-check workflow 3ware/workflows
1 participant
@chris3ware