Bump @cypress/request and cypress + Pattern updates as per supported WP versions + WP bump to 6.2 as min and 6.4 as max #166
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [@cypress/request](https://github.com/cypress-io/request) to 3.0.1 and updates ancestor dependency [cypress](https://github.com/cypress-io/cypress). These dependencies need to be updated together. Updates `@cypress/request` from 2.88.12 to 3.0.1 - [Release notes](https://github.com/cypress-io/request/releases) - [Changelog](https://github.com/cypress-io/request/blob/master/CHANGELOG.md) - [Commits](cypress-io/request@v2.88.12...v3.0.1) Updates `cypress` from 11.2.0 to 13.3.0 - [Release notes](https://github.com/cypress-io/cypress/releases) - [Changelog](https://github.com/cypress-io/cypress/blob/develop/CHANGELOG.md) - [Commits](cypress-io/cypress@v11.2.0...v13.3.0) --- updated-dependencies: - dependency-name: "@cypress/request" dependency-type: indirect - dependency-name: cypress dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
type:dependency
There was a problem hiding this comment.
@dkotter I have tested this in local and the cypress tests are running and passing without any errors
But here in the pipeline it is failing (tried re-running them too but no luck). In such cases, how should we proceed?
|
@faisal-alvi Tested myself and tests do pass if running on our minimum WordPress version (5.7) but if running on the latest version or on trunk, it then fails with the same error seen here. I think the solve here is to follow the steps in #164, most importantly updating the |
|
Fine by me to simplify things and resolve within this PR |
this fixes: 
faisal-alvi
changed the title
|
@faisal-alvi please keep us posted when this PR is ready for review as once this gets merged in then that will also unblock #165 |
github-actions
bot
added
the
needs:refresh
|
@dependabot thanks for the PR! Could you please rebase your PR on top of the latest changes in the base branch? |
|
Noting that I talked with @faisal-alvi on this and he'll test to see if WP 6.2 resolves the concerns, if so we'll set that as our minimum and test WP 6.4 and make that the max for PMK. |
|
So the new changes include:
Note: I had to use force click because even running the |
faisal-alvi
requested review from
a team and
jeffpaul
and removed request for
a team
faisal-alvi
changed the title
Sidsector9
changed the title
There was a problem hiding this comment.
I'm not sure this is a problem introduced with this PR (seems to be an issue on the develop branch as well) but I'm running into a few issues we should resolve.
The main one is the Tab block does not render in the editor for the Media Kit page but does render on the front end:
I'm also getting some console errors that may or may not be related:
TypeError: Cannot read properties of null (reading 'getBoundingClientRect') in editor.js
and
The block "tenup/tabs-item" is registered with an invalid category "tenup-blocks".
and
publisher_media_kit_admin-css was added to the iframe incorrectly. Please use block.json or enqueue_block_assets to add styles to the iframe
…ry "tenup-blocks".
|
@dkotter please check now. |
There was a problem hiding this comment.
The tabs block shows in the editor now but when clicking into a Tab Item, I get the same editor error. Console shows this:
Uncaught TypeError: Cannot read properties of null (reading 'setAttribute')
TypeError: Cannot read properties of null (reading 'classList')
|
|
||
| // Register block pattern for cover image. | ||
| ob_start(); | ||
| include_once PUBLISHER_MEDIA_KIT_BLOCK_PATTERS . $cover_patter_file . '.php'; | ||
| include_once PUBLISHER_MEDIA_KIT_BLOCK_PATTERS . 'cover-esperanza.php'; |
There was a problem hiding this comment.
Is there any concern here for sites that may have been using this cover pattern, since we're deleting it now? Not sure if that will cause issues for them or not
There was a problem hiding this comment.
no concerns, the patterns are just HTML markup (i.e. static) it does not matter if we change the markup file or delete it.
I've tried to regenerate but the tab block working as expected for me. I'm using Storefront v4.5.3 and only PMK plugin active in WP v6.4.2. Can you please share the steps to regenerate so it would be easy for me to fix?
|
Tested this again on a new environment and it is working. Debugged a bit on the environment that is having a problem and it seems to be an issue with the Gutenberg plugin. If I deactivate that plugin, things work fine but with it active, the tab items break. My main concern here is typically what is in the Gutenberg plugin ends up making it into WordPress core, so I imagine this will be a wider issue within the next WordPress release or two (so may be worth looking into now). One other issue I found though is if I deactivate the PMK plugin, delete the Media Kit page and then reactivate PMK, it recreates the Media Kit (which is good). When editing this page though, I get a block error: There's also a console error:
|
|
@dkotter Thanks, I was able to generate the |
There was a problem hiding this comment.
Nice work here @faisal-alvi!
Note I tested the following scenarios:
Test update for existing installs
- Install and activate the current released version of PMK and have it create the Media Kit page
- Download the changes in this branch and ensure that page still functions correctly in the editor and looks correct on the front-end
Test new installs
- Delete the Media Kit page and delete the PMK plugin
- Download the plugin from this branch and activate it
- Ensure the Media Kit page is created and functions correctly
faisal-alvi
deleted the
dependabot/npm_and_yarn/cypress/request-and-cypress-3.0.1
branch
Bumps @cypress/request to 3.0.1 and updates ancestor dependency cypress. These dependencies need to be updated together.
Updates
@cypress/requestfrom 2.88.12 to 3.0.1Release notes
Sourced from
@cypress/request's releases.Changelog
Sourced from
@cypress/request's changelog.... (truncated)
Commits
ca62f3aMerge pull request #44 from MikeMcC399/peg/qsfb9f625fix(deps): peg qs to 6.10.499338c8chore: updates related to release process (#41)c5bcf21feat: Add allowInsecureRedirect optionUpdates
cypressfrom 11.2.0 to 13.3.0Release notes
Sourced from cypress's releases.
... (truncated)
Commits
0871b03chore: update 13.3.0 release date in changelog (#27918)1ec045fchore: fix action to properly add PR to the Triage Board for visibility (#27917)a1b4124chore: release 13.3.0 (#27900)b114dcefix: statusCode allow 999 (#27853)dbfb3e6chore: Update installation requirements in CONTRIBUTING.md (#27878)b1efbafchore(deps): update dependency systeminformation to v5.21.7 [security] (#27874)199f4c3chore: remove KPI generation workflow (#27887)273d8cechore: skip binary jobs if we don't have a circle token (#27876)ce17a44fix: issue with font flooding (#27860)154311achore: gate restricted contexts with approval job for contributor workflow (#...You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.