Conversation
tomyrd
added
no changelog
tomyrd
force-pushed
the
tomyrd-update-miden-vm
branch
2 times, most recently
from
eb39a11 to
c0b154a
Compare
Collaborator
|
Should we serialize the |
tomyrd
force-pushed
the
tomyrd-update-miden-vm
branch
from
c0b154a to
96f853e
Compare
igamigo
approved these changes
May 20, 2025
Collaborator
igamigo
left a comment
igamigo
left a comment
There was a problem hiding this comment.
LGTM, thanks! Could you add an issue to track the source manager work?
SantiagoPittella
approved these changes
May 21, 2025
tomyrd
force-pushed
the
tomyrd-update-miden-vm
branch
from
057ca9d to
d617a23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the updates from 0xMiden/miden-base#1353 to the client.
One of the main changes is the introduction of the
SourceManagerfor the executor. Right now we are just using the default implementation, but ideally we would use the source manager from the assembler used to compile code. The main problem with this is that generally we compile code with freshly instantiated assemblers each time (e.g. for account/note/transaction code) and we mostly don't have access to each one.We should look to refactor
miden-baseandmiden-clientto allow to share assemblers at every stage so that the usedSourceManagercan contain all the debug information.