feat: update Miden VM in client (#913)

* feat: update `miden-base` with new 0.14 VM

* use stable version for `miden-base`

Author: tomyrd

Cargo.lock

@@ -20,10 +20,10 @@ repository = "https://github.com/0xMiden/miden-client"
 
 [workspace.dependencies]
 async-trait = "0.1"
-miden-lib = { git = "https://github.com/0xMiden/miden-base", branch = "next", default-features = false }
-miden-objects = { git = "https://github.com/0xMiden/miden-base", branch = "next", default-features = false }
-miden-tx = { git = "https://github.com/0xMiden/miden-base", branch = "next", default-features = false, features = ["async"] }
-miden-proving-service-client = { git = "https://github.com/0xMiden/miden-base", branch = "next",  default-features = false, features = ["tx-prover"] }
+miden-lib = { version = "0.9" , default-features = false }
+miden-objects = { version = "0.9" , default-features = false }
+miden-tx = { version = "0.9" , default-features = false, features = ["async"] }
+miden-proving-service-client = { version = "0.9" ,  default-features = false, features = ["tx-prover"] }
 miette = { version = "7.2", features = ["fancy"] }
 rand = { version = "0.9" }
 serde = { version = "1.0", features = ["derive"] }

Cargo.toml

@@ -18,7 +18,7 @@ WARNINGS=RUSTDOCFLAGS="-D warnings"
 
 PROVER_DIR="miden-base"
 PROVER_REPO="https://github.com/0xMiden/miden-base.git"
-PROVER_BRANCH="3d8c3b28048fffbb63592a971d0fcae5dc58bce9"
+PROVER_BRANCH="next"
 PROVER_FEATURES_TESTING=--features "testing"
 PROVER_PORT=50051
 

Makefile

@@ -63,7 +63,7 @@ web-sys = { version = "0.3", features = ["console", "Window", "Storage"] }
 miden-client = { path = ".", features = ["testing", "concurrent", "sqlite", "tonic"] }
 miden-lib = { workspace = true, features = ["testing"] }
 miden-objects = { workspace = true, default-features = false, features = ["testing"] }
-miden-testing = { git = "https://github.com/0xMiden/miden-base", branch = "next", default-features = false, features = ["async"] }
+miden-testing = { version = "0.9" , default-features = false, features = ["async"] }
 tokio = { workspace = true }
 uuid = { version = "1.10", features = ["serde", "v4"] }
 web-sys = { version = "0.3", features = ["console"]}

crates/rust-client/Cargo.toml

@@ -73,6 +73,7 @@ use core::fmt::{self};
 use miden_objects::{
     AssetError, Digest, Felt, Word,
     account::{Account, AccountCode, AccountDelta, AccountId},
+    assembly::DefaultSourceManager,
     asset::{Asset, NonFungibleAsset},
     block::BlockNumber,
     note::{Note, NoteDetails, NoteId, NoteTag},
@@ -549,7 +550,13 @@ impl Client {
         // Execute the transaction and get the witness
         let executed_transaction = self
             .tx_executor
-            .execute_transaction(account_id, block_num, notes, tx_args)
+            .execute_transaction(
+                account_id,
+                block_num,
+                notes,
+                tx_args,
+                Arc::new(DefaultSourceManager::default()), // TODO: Use the correct source manager
+            )
             .await?;
 
         // Check that the expected output notes matches the transaction outcome.
@@ -1023,6 +1030,7 @@ impl Client {
                 tx_script,
                 advice_inputs,
                 foreign_account_inputs,
+                Arc::new(DefaultSourceManager::default()), // TODO: Use the correct source manager
             )
             .await?)
     }

crates/rust-client/src/transaction/mod.rs

@@ -296,7 +296,7 @@ export const customTransaction = async (
                 mem_loadw
                 # => [NOTE_ARG_1]
 
-                push.${expectedNoteArg1} assert_eqw.err=101
+                push.${expectedNoteArg1} assert_eqw.err="First note argument didn't match expected"
                 # => []
 
                 # read second word
@@ -305,15 +305,15 @@ export const customTransaction = async (
                 mem_loadw
                 # => [NOTE_ARG_2]
 
-                push.${expectedNoteArg2} assert_eqw.err=102
+                push.${expectedNoteArg2} assert_eqw.err="Second note argument didn't match expected"
                 # => []
 
                 # store the note inputs to memory starting at address 0
                 push.0 exec.note::get_inputs
                 # => [num_inputs, inputs_ptr]
 
-                # make sure the number of inputs is 1
-                eq.2 assert.err=103
+                # make sure the number of inputs is 2
+                eq.2 assert.err="P2ID script expects exactly 2 note inputs"
                 # => [inputs_ptr]
 
                 # read the target account id from the note inputs
@@ -324,7 +324,7 @@ export const customTransaction = async (
                 # => [account_id_prefix, target_account_id_prefix, ...]
 
                 # ensure account_id = target_account_id, fails otherwise
-                assert_eq.err=104
+                assert_eq.err="P2ID's target account address and transaction address do not match"
                 # => [...]
 
                 exec.add_note_assets_to_account

crates/web-client/test/new_transactions.test.ts

@@ -83,7 +83,7 @@ begin
     mem_loadw
     # => [NOTE_ARG_1]
 
-    push.{expected_note_arg_1} assert_eqw.err=101
+    push.{expected_note_arg_1} assert_eqw.err="First note argument didn't match expected"
     # => []
 
     # read second word
@@ -92,15 +92,15 @@ begin
     mem_loadw
     # => [NOTE_ARG_2]
 
-    push.{expected_note_arg_2} assert_eqw.err=102
+    push.{expected_note_arg_2} assert_eqw.err="Second note argument didn't match expected"
     # => []
 
     # store the note inputs to memory starting at address 0
     push.0 exec.note::get_inputs
     # => [num_inputs, inputs_ptr]
 
-    # make sure the number of inputs is 1
-    eq.2 assert.err=103
+    # make sure the number of inputs is 2
+    eq.2 assert.err="P2ID script expects exactly 2 note inputs"
     # => [inputs_ptr]
 
     # read the target account id from the note inputs
@@ -111,7 +111,7 @@ begin
     # => [account_id_prefix, target_account_id_prefix, ...]
 
     # ensure account_id = target_account_id, fails otherwise
-    assert_eq.err=104
+    assert_eq.err="P2ID's target account address and transaction address do not match"
     # => [...]
 
     exec.add_note_assets_to_account

tests/integration/asm/custom_p2id.masm

@@ -200,7 +200,7 @@ async fn test_merkle_store() {
             push.4000 push.{pos} exec.mmr::get
 
             # check the element matches what was inserted at `pos`
-            push.{expected_element} assert_eqw.err=999
+            push.{expected_element} assert_eqw.err=\"element in merkle store didn't match expected\"
         "
         )
         .as_str();