homescreen_icon: Swap All-Messages icon from 'globe' to 'list'. - #5471
dootMaster wants to merge 2 commits into
Conversation
to ready the component for icon swap. TopTabButtonGeneral can consume the SpecificIconType component, which can return icons from FontAwesome collection. TopTabButton currently returns icons from the Feather collection.
to match mobile's All Messages icon with the one found in web Zulip. Fixes: zulip#5303
|
Regarding the previous PR review from Chris:
I've swapped the Feather icon for the FontAwesome one, but I noticed the new list icon from the FontAwesome collection doesn't quite match the aesthetic of the rest of the icons. The lines are bolder. What do ya'll think? |
|
One solution would be to to invert the old Feather list icon via the transform in the style prop. I'm going to try it and post the result. |
Huh, interesting! Sure, that seems fine; thanks for the screenshot! |
|
Agreed -- @dootMaster, I'd be glad to see a version of this PR that does what you showed in that last screenshot 🙂 |




to match mobile's All Messages icon with the one found in web Zulip.
Previous Mobile:

Browser:

Update Mobile:

Fixes: #5303