test [nfc]: Remove WidgetTester type annotation from testWidgets tests.#860
Merged
gnprice merged 1 commit intozulip:mainfrom Aug 11, 2024
Merged
Conversation
PIG208
changed the title
PIG208
force-pushed
the
avoid_types_on_closure_parameters
branch
from
2664128 to
ce76b68
Compare
PIG208
changed the title
PIG208
force-pushed
the
avoid_types_on_closure_parameters
branch
from
ce76b68 to
2fd3301
Compare
Collaborator
|
Thanks, LGTM! Over to Greg for his review. |
chrisbobbe
added
integration review
PIG208
force-pushed
the
avoid_types_on_closure_parameters
branch
from
2fd3301 to
fdac15e
Compare
Member
Author
|
Rebased the PR. |
Member
|
Thanks for cleaning this up! The changes all look good. Would you rebase atop main? |
This consists of handpicked output from running the dart lint fix for code `avoid_types_on_closure_parameters`. We probably don't need to enable this linter rule because in many cases the type annotation improves readability. For the `(WidgetTester tester)` case, though, it is common and intuitive enough that the annotation shouldn't be necessary. See also: zulip#762 (comment) Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208
force-pushed
the
avoid_types_on_closure_parameters
branch
from
fdac15e to
0a9cf7f
Compare
Member
Author
|
Did another sweep and rebased the PR. |
Member
|
Thanks! Looks good — merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This consists of handpicked output from running the dart lint fix for code
avoid_types_on_closure_parameters. We probably don't need to enable this linter rule because in many cases the type annotation improves readability. For the(WidgetTester tester)case, though, it is common and intuitive enough that the annotation shouldn't be necessary.See also:
#762 (comment)