-
Notifications
You must be signed in to change notification settings - Fork 308
#171 : Show edited/moved marker on messages #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CI failed probably because I did not add the generated files to the commit. Will do so soon. |
Thanks for the contribution! In addition to getting the existing tests passing, before we can review this PR in detail you'll need to write tests for it — see the note in the README file. If you have questions as you try to do that, we're happy to discuss in |
Please also post screenshots. That helps people review the UI changes. |
I've edited the PR description to link it up with the issue, to make it easy to find when looking at the issue. When the PR is ready for review, just post a comment here saying so and then I can take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the revision!
Some quick comments below on the code so far.
One thing we'll need before we can fully review this PR is for the changes to be organized into clear and coherent commits. See the relevant README section:
https://github.com/zulip/zulip-flutter#submitting-a-pull-request
From the screenshots, it looks like this UI doesn't yet match the design in at least one important way: pay close attention to where the edited/moved markers are when at rest, before swiping to show the word "Edited" or "Moved".
# Set fallback configurations for older versions of the flutter tool. | ||
if (NOT DEFINED FLUTTER_TARGET_PLATFORM) | ||
set(FLUTTER_TARGET_PLATFORM "windows-x64") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks unrelated to the rest of the PR. As part of making clear and coherent commits:
https://zulip.readthedocs.io/en/latest/contributing/commit-discipline.html
it'll therefore need to be its own commit, with a commit message explaining why we want to make this change.
Haven't added the zulip icons yet, since I wasn't able to run the script to auto generate the icons.dart file.
Fixes: #171