content [nfc]: s/image/image preview/, making room for new "inline image" #1923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajveermalviya
approved these changes
Oct 17, 2025
rajveermalviya
added
integration review
gnprice
reviewed
Oct 18, 2025
|
|
||
| class MessageImage extends StatelessWidget { | ||
| const MessageImage({super.key, required this.node}); | ||
| class MessageImagePreview extends StatelessWidget { |
There was a problem hiding this comment.
nit: git grep -w MessageImage finds one straggler reference in a comment
The linked discussion is about adding documentation; we can link to that documentation once it's added.
…age" The API doc is being updated to distinguish the current "image preview" content node from a new one, "image element presented in Markdown syntax", which I think we'll just call "inline image". See PR in progress: zulip/zulip#36226 Related: zulip#1913
chrisbobbe
force-pushed
the
pr-rename-image-to-image-preview
branch
from
c63d768 to
51dbd2c
Compare
|
Thanks! Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1913