Get route-transition duration robustly,instead of hard-coding

[MdSaifAliMolla]

closes #1668

[gnprice]

Thanks. Some of these changes look good, but there are other places where a lot more code is getting changed and it's not obvious what the reasons for those changes are. That makes it considerably more work for someone to review, because they have to read through all those changes and reverse-engineer what your intent is.

Please take a look at our guide to writing a clean commit history:
https://zulip.readthedocs.io/en/latest/contributing/commit-discipline.html#write-a-clean-commit-history
and then try using those ideas to make this PR an efficient one for someone to review. So:

• avoid any changes that aren't relevant;
• and if there are places where you think a more complex change is needed, make that a separate commit with a commit message explaining why.

[MdSaifAliMolla]

@gnprice I guess it's fine now.

[gnprice]

This is improved, but there are still some places like this:

where a lot more code is getting changed and it's not obvious what the reasons for those changes are. That makes it considerably more work for someone to review, because they have to read through all those changes and reverse-engineer what your intent is.

For example:

-      testWidgets('can show snackbar on success', (tester) async {
-        // Regression test for: https://github.com/zulip/zulip-flutter/issues/732
-        testBinding.deviceInfoResult = const IosDeviceInfo(systemVersion: '16.0');
-
-        final message = eg.streamMessage();
-        await setupToMessageActionSheet(tester, message: message, narrow: TopicNarrow.ofMessage(messa
ge));
+    testWidgets('can show snackbar on success', (WidgetTester tester) async {
+      // Regression test for: https://github.com/zulip/zulip-flutter/issues/732
+      final TransitionDurationObserver transitionDurationObserver = TransitionDurationObserver();
+      await tester.pumpWidget(
+        MaterialApp(
+          navigatorObservers: <NavigatorObserver>[transitionDurationObserver],
+          home: Scaffold(
+            body: Builder(
+              builder: (context) {
+                testBinding.deviceInfoResult = const IosDeviceInfo(systemVersion: '16.0');
+                final message = eg.streamMessage();
+                setupToMessageActionSheet(tester,message: message,narrow: TopicNarrow.ofMessage(messa
ge));
+                return const SizedBox.shrink();}
+            ))));
+      final message = eg.streamMessage();
+       // Make the request take a bit of time to complete
+      prepareRawContentResponseSuccess(message: message,rawContent: 'Hello world',delay: const Durati
on(milliseconds: 500),
+      );
+      await tapCopyMessageTextButton(tester);
+      // … and pump a frame to finish the NavigationState.pop animation…
+      await transitionDurationObserver.pumpPastTransition(tester);
+      // … before the request finishes.  This is the repro condition for #732.
+      await transitionDurationObserver.pumpPastTransition(tester);
 
-        // Make the request take a bit of time to complete…
-        prepareRawContentResponseSuccess(message: message, rawContent: 'Hello world',
-          delay: const Duration(milliseconds: 500));
-        await tapCopyMessageTextButton(tester);
-        // … and pump a frame to finish the NavigationState.pop animation…
-        await tester.pump(const Duration(milliseconds: 250));
-        // … before the request finishes.  This is the repro condition for #732.
-        await tester.pump(const Duration(milliseconds: 250));
+      final snackbar = tester.widget<SnackBar>(find.byType(SnackBar));
+      check(snackbar.behavior).equals(SnackBarBehavior.floating);
 
-        final snackbar = tester.widget<SnackBar>(find.byType(SnackBar));
-        check(snackbar.behavior).equals(SnackBarBehavior.floating);
-        final zulipLocalizations = GlobalLocalizations.zulipLocalizations;
-        tester.widget(find.descendant(matchRoot: true,
+      final zulipLocalizations = GlobalLocalizations.zulipLocalizations;
+      tester.widget(find.descendant(matchRoot: true,
           of: find.byWidget(snackbar.content),
-          matching: find.text(zulipLocalizations.successMessageTextCopied)));
-      });
+          matching: find.text(zulipLocalizations.successMessageTextCopied),
+        ));
+    });
+

Take a look again at the changes in your PR. Use git log -p, or a graphical Git viewer, to see exactly what changes you have. Then please revise to accomplish this as far as you can:

[…] to make this PR an efficient one for someone to review. So:

• avoid any changes that aren't relevant;
• and if there are places where you think a more complex change is needed, make that a separate commit with a commit message explaining why.

[MdSaifAliMolla]

@gnprice done. Followed this flutter/flutter#171109 coding convention as suggested here #1668, otherwise the tests kept failing. fixed indentation mismatch related diffs(mostly).

[gnprice]

This revision is somewhat improved again, but there are still some irrelevant changes, and still some places where more code is getting changed and it's not clear exactly why.

If you need help in doing this:

Take a look again at the changes in your PR. Use git log -p, or a graphical Git viewer, to see exactly what changes you have. Then please revise to accomplish this as far as you can:

[…] to make this PR an efficient one for someone to review. So:

• avoid any changes that aren't relevant;
• and if there are places where you think a more complex change is needed, make that a separate commit with a commit message explaining why.

then the #git-help channel on chat.zulip.org is a good place to ask.

fixed indentation mismatch related diffs(mostly).

Why mostly and not entirely?

Followed this flutter/flutter#171109 coding convention as suggested here #1668, otherwise the tests kept failing.

I don't understand this comment. #1668 is the issue this PR is meant to fix, so in general these changes should be in the direction called for by that issue. If you're encountering test failures that you don't understand the cause of, then the #mobile-dev-help channel is the best venue to ask about them.