-
Notifications
You must be signed in to change notification settings - Fork 340
compose_box: Add start video call button in compose #1916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
9f3ca6c
to
e6c9afb
Compare
5ab42a9
to
b2bb501
Compare
Thanks. It looks like you still have a TODO item before this is ready to be reviewed, so marking it as draft for now. |
4cd6e12
to
576234b
Compare
All the TODO are done @gnprice! |
Thanks. Before this can be reviewed, you'll need to revise it to have clear and coherent commits. See the instructions we discussed on a previous PR thread: #1830 (review) |
334e77f
to
e6835e8
Compare
e6835e8
to
8a417e9
Compare
Thanks @gnprice for suggesting the refinement in commit history to make sure it becomes minimal and coherent. The same has been implemented. |
Thanks. Some of these commits aren't coherent. For example this commit f314a74:
can't be right, because it says it involved One useful step for spotting this kind of issue is to run our tests at every commit. If they fail, the commit needs fixing. It's straightforward to do that by hand. But a command which can be a useful shortcut for it is this: |
This commit is the result of the following commands: flutter pub upgrade --major-version pigeon tools/check --all-files --fix pigeon Changelog: https://pub.dev/packages/pigeon/changelog#2602
This commit adds function and then Configure to generate jitsi unique meeting ID and to fetch video chat url as per realmVideoChatProvider
8a417e9
to
60c8367
Compare
Thank you @gnprice for taking time to review the commit history and for the useful shortcut. It was very handy and i was easily able to trace the coherent status of each commit and resolve them on the go. Following i have done the updates in the commit history to maintain coherent commit with optimized minimalism. |
Fixes #1824
Design
Light Theme
XRecorder_20251015_04.mp4
Dark Theme
XRecorder_20251015_05.mp4