Skip to content

Clear out some backwards-compat code; inline store.userDisplayEmail #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2025
Merged

Clear out some backwards-compat code; inline store.userDisplayEmail #1768

merged 2 commits into from
Jul 30, 2025

Conversation

chrisbobbe
Copy link
Collaborator

No description provided.

@chrisbobbe chrisbobbe added the maintainer review PR ready for review by Zulip maintainers label Jul 29, 2025
rajveermalviya
rajveermalviya approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@rajveermalviya rajveermalviya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chrisbobbe! LGTM.

@rajveermalviya rajveermalviya added integration review Added by maintainers when PR may be ready for integration and removed maintainer review PR ready for review by Zulip maintainers labels Jul 30, 2025
@rajveermalviya rajveermalviya requested a review from gnprice July 30, 2025 18:27
@chrisbobbe @gnprice
user [nfc]: Clear out pre-7.0 backwards-compat code for display email
0900820 
We refuse to connect to servers older than 7.0; see the README and
kMinSupportedZulipVersion.
@chrisbobbe @gnprice
user [nfc]: Inline store.userDisplayEmail, which has become trivial
a89d96e 
For zulip#236 matching users by email address, we'd like to add some
fields to AutocompleteDataCache, and that'll be simpler if we don't
have to involve the whole UserStore.
@gnprice
Copy link
Member

gnprice commented Jul 30, 2025

Thanks for the cleanup! Looks good; merging, with one commit-message tweak:

  ## Commit message ##
-    store [nfc]: Inline store.userDisplayEmail, which has become trivial
+    user [nfc]: Inline store.userDisplayEmail, which has become trivial

For changes that belong to a particular substore, I've been using the substore for the summary-line prefix to make it a bit more specific.

@gnprice gnprice force-pushed the pr-user-display-email branch from 15cd08a to a89d96e Compare July 30, 2025 19:16
@gnprice gnprice merged commit a89d96e into zulip:main Jul 30, 2025
1 check passed
@chrisbobbe
Copy link
Collaborator Author

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajveermalviya rajveermalviya rajveermalviya approved these changes

@gnprice gnprice Awaiting requested review from gnprice

Assignees

@gnprice gnprice

Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisbobbe @gnprice @rajveermalviya