Add comment for GetFoldParent() change.

zufuliu · Jan 18, 2024 · 4768422 · 4768422
1 parent b71af2f
commit 4768422
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/scintilla/src/PerLine.cxx b/scintilla/src/PerLine.cxx
@@ -279,7 +279,11 @@ Scintilla::FoldLevel LineLevels::GetFoldLevel(Sci::Line line) const noexcept {
 Sci::Line LineLevels::GetFoldParent(Sci::Line line) const noexcept {
 	if (IsValidIndex(line, levels.Length())) {
 		const FoldLevel level = LevelNumberPart(GetFoldLevel(line));
-		if (level == FoldLevel::Base) {
+		// optimized for current block highlighting to avoid checking all previous lines,
+		// bug will occur for negative code folding level,
+		// see https://sourceforge.net/p/scintilla/feature-requests/1444/
+		// and https://github.com/ScintillaOrg/lexilla/issues/224
+		if (level <= FoldLevel::Base) {
 			return -1;
 		}
 		for (Sci::Line lineLook = line - 1; lineLook >= 0; lineLook--) {