Minor code refactoring.

zufuliu · Dec 24, 2023 · 1f3f202 · 1f3f202
1 parent e8db1a1
commit 1f3f202
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -13,6 +13,7 @@ Checks: >
     misc-*,
     -clang-analyzer-security.insecureAPI.strcpy,
     -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
+    -clang-analyzer-optin.core.EnumCastOutOfRange,
     -bugprone-easily-swappable-parameters,
     -bugprone-implicit-widening-of-multiplication-result,
     -bugprone-narrowing-conversions,

diff --git a/src/Helpers.c b/src/Helpers.c
@@ -2582,8 +2582,7 @@ HBITMAP BitmapCache_Get(BitmapCache *cache, LPCWSTR path) {
 	cache->used |= 1U << index;
 	HBITMAP hbmp = cache->items[index];
 	if (hbmp == NULL) {
-		HDC hDC = GetDC(NULL);
-		HDC bitmapDC = CreateCompatibleDC(hDC);
+		HDC bitmapDC = CreateCompatibleDC(NULL);
 		int width = 0;
 		int height = 0;
 		ImageList_GetIconSize(imageList, &width, &height);
@@ -2593,7 +2592,6 @@ HBITMAP BitmapCache_Get(BitmapCache *cache, LPCWSTR path) {
 		ImageList_Draw(imageList, iIcon, bitmapDC, 0, 0, ILD_TRANSPARENT);
 		SelectBitmap(bitmapDC, oldBitmap);
 		DeleteDC(bitmapDC);
-		ReleaseDC(NULL, hDC);
 		cache->items[index] = hbmp;
 	}
 

diff --git a/src/Helpers.h b/src/Helpers.h
@@ -110,6 +110,10 @@ NP2_inline bool IsASpaceOrTab(int ch) {
 	return ch == ' ' || ch == '\t';
 }
 
+NP2_inline bool IsADigit(int ch) {
+	return ch >= '0' && ch <= '9';
+}
+
 NP2_inline bool IsOctalDigit(int ch) {
 	return ch >= '0' && ch <= '7';
 }