get rid of Obj.magic in doLoadRouteRenderer #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsnobip
force-pushed
the
simplify_prop_types
branch
from
600c6d6 to
d41c8f9
Compare
tsnobip
commented
Sep 15, 2023
Comment on lines
-523
to
+506
| let loadRouteRenderer = () => (() => Js.import(${routeName}_route_renderer.renderer))->Obj.magic->doLoadRouteRenderer(~routeName, ~loadedRouteRenderers) | ||
| let loadRouteRenderer = () => (() => Js.import(${routeName}_route_renderer.renderer))->doLoadRouteRenderer(~routeName, ~loadedRouteRenderers) |
There was a problem hiding this comment.
this is the main Obj.magic that got removed
Comment on lines
-504
to
-509
| str.contents ++ `@obj | ||
| external makeRenderer: ( | ||
| ~prepare: Internal.prepareProps => 'prepared, | ||
| ~prepareCode: Internal.prepareProps => array<RelayRouter.Types.preloadAsset>=?, | ||
| ~render: Internal.renderProps<'prepared> => React.element, | ||
| ) => Internal.renderers<'prepared> = ""` |
There was a problem hiding this comment.
I also removed this @obj external that could become out of sync with its underlying type
Comment on lines
-138
to
-139
| external unsafe_toPrepareProps: 'any => prepareProps = "%identity" | ||
There was a problem hiding this comment.
I replaced it with a safer:
external unsafe_toPrepareProps: prepareProps<'a> => prepareProps<'b> = "%identity"in RelayRouter__Internal__DeclarationsSupport.res
tsnobip
force-pushed
the
simplify_prop_types
branch
from
d41c8f9 to
4ac6dfb
Compare
also made unsafe_toPrepareProps safer removed unsafe makeRenderer
tsnobip
force-pushed
the
simplify_prop_types
branch
from
4ac6dfb to
0ec4a8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I worked on removing the unsafe operations as much as possible.
This would allow us to track bugs like the one that got fixed by #141.
It is a breaking change given I removed the unsafe
makeRendererand replaced it by a simple record with an optional field forprepareCode. Though I believe removing those layers of "unsafe magic" is worth it.Let me know what you think.
ps. I didn't touch the LSP support at all, so it might need some love.